Bug 8036 - Goto into (inside) switch-case
Summary: Goto into (inside) switch-case
Status: RESOLVED FIXED
Alias: None
Product: Compilers
Classification: Mono
Component: C# ()
Version: unspecified
Hardware: PC Linux
: --- normal
Target Milestone: ---
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2012-10-28 12:50 UTC by Lukáš Fireš
Modified: 2012-10-29 08:10 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Lukáš Fireš 2012-10-28 12:50:37 UTC
switch(...) {
case ...:
  something();
label:
  common();
  break;
case ...:
  different();
  goto label;
}

Can be compiled with Visual Studio ;)

Workaround #1:
bool doit = false;
switch(...) {
case ...:
  something();
  doit = true;
  break;
case ...:
  different();
  doit = true;
  break;
}
if(doit) common();

Workaround #2
switch(...) {
case ...:
  something();
  common(all_vars);
  break;
case ...:
  different();
  common(all_vars);
  break;
}

Real code:
public override string DataString() {
	int at = hdrlen;
	StringBuilder sb = new StringBuilder();
	if(type == TYPE.MDBG)
		sb.AppendFormat(FormatProvider, "x{0:D} ", count);
	bool phex = true;
	bool ptxt = true;
	bool gsta = false;
	switch(code) {
// not needed code removed
	case 62: sb.Append("GPRS-URX");
	packet:
		switch(data.getb(at)) {
// not needed code removed
		}
		ptxt = false;
		break;
	case 63: sb.Append("GPRS-FCS"); goto packet;
...
Comment 1 Lukáš Fireš 2012-10-28 12:57:32 UTC
Found similar bugreport here:
https://bugzilla.novell.com/show_bug.cgi?id=671488
Comment 2 Marek Safar 2012-10-29 08:10:46 UTC
Fixed in master