Bug 6865 - Refactor -> Implement abstract members invalid modifiers
Summary: Refactor -> Implement abstract members invalid modifiers
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Text Editor ()
Version: Trunk
Hardware: PC Linux
: Normal normal
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2012-09-03 11:56 UTC by ventsislav mladenov
Modified: 2012-11-20 03:22 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description ventsislav mladenov 2012-09-03 11:56:04 UTC
When implementing abstract members the Refactor creates members with public modifier but if the base abstract method is protected - this leads to error. 

protected abstract string ServiceName { get; }

creates:

        public override string ServiceName
        {
            get
            {
                throw new NotImplementedException();
            }
        }

it should be:

        protected override string ServiceName
        {
            get
            {
                throw new NotImplementedException();
            }
        }
Comment 1 Mike Krüger 2012-09-04 02:20:33 UTC
fixed.
Comment 2 Roland Mai 2012-11-17 23:12:15 UTC
As of 3.0.5 in macs the issue persists.
Comment 3 Mike Krüger 2012-11-20 03:22:24 UTC
Didn't get backported to the 3.x branch