Bug 6553 - string.CompareOrdinal returns incorrect result
Summary: string.CompareOrdinal returns incorrect result
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: mscorlib ()
Version: master
Hardware: All All
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2012-08-16 07:30 UTC by Steffen Kieß
Modified: 2012-09-04 11:49 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Steffen Kieß 2012-08-16 07:30:09 UTC
string.CompareOrdinal incorrectly returns 0 if both string references point to the same object and the length parameter is small enough to fit into the string for both offsets but the offsets are different.

Steps to reproduce:
cat > StringCompare.cs <<EOF
public class StringCompare {
  public static void Main () {
    string ab1 = "ab";
    string ab2 = "a" + new string ('b', 1); // same string in new object
    System.Console.WriteLine (ab1);
    System.Console.WriteLine (ab2);
    System.Console.WriteLine (string.CompareOrdinal (ab1, 0, ab1, 1, 1)); // should return -1 (because second offset is 1)
    System.Console.WriteLine (string.CompareOrdinal (ab2, 0, ab1, 1, 1)); // correctly returns -1
  }
}
EOF
gmcs StringCompare.cs
mono StringCompare.exe

Actual result:
ab
ab
0
-1

Expected result:
ab
ab
-1
-1


This is caused by these lines in System.String.CompareOrdinalUnchecked:
                        if (lengthA == lengthB && Object.ReferenceEquals (strA, strB))
                                return 0;
There also should be a check here whether the offsets are equal.


This problem appears both in Mono 2.10.8.1 and in the current git master
(2e7da2d7657601ecac25c9c9bec2f9b5cfe3649f).
Comment 1 Marek Safar 2012-09-04 11:49:43 UTC
Fixed in master