Bug 60920 - LogProfiler is wrongly storing Counters Descriptions(Type, Variance, Unit) in .mlpd
Summary: LogProfiler is wrongly storing Counters Descriptions(Type, Variance, Unit) in...
Status: RESOLVED FIXED
Alias: None
Product: Runtime
Classification: Mono
Component: Profiler ()
Version: unspecified
Hardware: PC Mac OS
: Normal normal
Target Milestone: Future Cycle (TBD)
Assignee: Alex Rønne Petersen
URL:
Depends on:
Blocks:
 
Reported: 2017-11-30 04:44 UTC by David Karlaš
Modified: 2017-12-01 03:37 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description David Karlaš 2017-11-30 04:44:39 UTC
Issue is here: https://github.com/mono/mono/blob/0239710/mono/profiler/log.c#L2660-L2662
Problem is that mono_counter_get_type, mono_counter_get_unit and mono_counter_get_variance are not returning byte but uint, which are just masked. So I think log.c should do the shifting to get value into 0-255 range. Also notice that enums in managed reader needs fixing.
Comment 1 Alex Rønne Petersen 2017-11-30 07:12:29 UTC
We should just emit them as-is but encoded as LEB128 for simplicity and value parity with mono-counters.h.
Comment 2 Alex Rønne Petersen 2017-11-30 07:23:36 UTC
https://github.com/mono/mono/pull/6134