Bug 60828 - MonoTests.System.TimeZoneTest.GetUtcOffsetAtDSTBoundary fails
Summary: MonoTests.System.TimeZoneTest.GetUtcOffsetAtDSTBoundary fails
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: mscorlib ()
Version: master
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2017-11-23 10:49 UTC by Rolf Bjarne Kvinge [MSFT]
Modified: 2017-11-23 22:01 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Rolf Bjarne Kvinge [MSFT] 2017-11-23 10:49:42 UTC
Repro:

* Run corlib test suite (My TZ is CET). I'm on https://github.com/mono/mono/commit/718247da6f31bfa4d440c0530b9d35047f57d9bb

Errors and Failures:

1) GetUtcOffsetAtDSTBoundary (MonoTests.System.TimeZoneTest.GetUtcOffsetAtDSTBoundary)
     Expected: 01:00:00
  But was:  02:00:00

  at MonoTests.System.TimeZoneTest.GetUtcOffsetAtDSTBoundary () [0x000a1] in /work/mono/master/mono/mcs/class/corlib/Test/System/TimeZoneTest.cs:350 
  at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in /work/mono/master/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:305
Comment 1 Rolf Bjarne Kvinge [MSFT] 2017-11-23 12:31:19 UTC
From #runtime:

Rolf Kvinge [11:04] this mscorlib test is failing for me locally with mono/master:
```1) GetUtcOffsetAtDSTBoundary (MonoTests.System.TimeZoneTest.GetUtcOffsetAtDSTBoundary)
     Expected: 01:00:00
  But was:  02:00:00

  at MonoTests.System.TimeZoneTest.GetUtcOffsetAtDSTBoundary () [0x000a1] in /work/mono/master/mono/mcs/class/corlib/Test/System/TimeZoneTest.cs:350 
  at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in /work/mono/master/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:305 
```

Rolf Kvinge [11:05] is this a known issue?
Marek Safar [11:12] yes, the tests assumes different local timezone
Comment 2 Rolf Bjarne Kvinge [MSFT] 2017-11-23 16:58:47 UTC
The broken check is disabled here: https://github.com/mono/mono/pull/6089
Comment 3 Marek Safar 2017-11-23 22:01:16 UTC
Fixed in master and 2017-10