Bug 60537 - [ios11] LABiometryType.TypeFaceId enum name not consistent
Summary: [ios11] LABiometryType.TypeFaceId enum name not consistent
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 11.0 (xcode9)
Hardware: Macintosh Mac OS
: Normal enhancement
Target Milestone: xcode9.2
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2017-11-06 19:49 UTC by CraigD
Modified: 2017-11-09 20:47 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: No
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description CraigD 2017-11-06 19:49:52 UTC
The three values for LABiometryType are:

LABiometryType.None
LABiometryType.TouchId
LABiometryType.TypeFaceId

the name for the last entry seems inconsistent -- should be just "FaceId"

fyi link to apple's doc https://developer.apple.com/documentation/localauthentication/labiometrytype
Comment 1 Alex Soto [MSFT] 2017-11-07 05:56:46 UTC
Ouch, I am the one to blame on that one, unfortunately that ship has sailed and we can't change it because it would be a breaking change :(

I will add the fix and add it under XAMCORE_4_0 so when the next breaking changes round happens it is fixed. Thanks Craig.
Comment 2 Sebastien Pouliot 2017-11-07 18:40:46 UTC
It's an enum so we can expose a new `FaceId` one (we just can't removed the existing one).

I'll include this while updating the LocalAuthentication bindings for Xcode 9.2
Comment 3 Alex Soto [MSFT] 2017-11-09 15:05:29 UTC
PR: https://github.com/xamarin/xamarin-macios/pull/2989
Comment 4 Sebastien Pouliot 2017-11-09 20:47:51 UTC
Merged in xcode9.2 with https://github.com/xamarin/xamarin-macios/commit/bb05a29b6b698d258dc606edc99df6c051517aba