Bug 60355 - [Enhancement] Update CGAffineTransform Multiply method to match native naming of Concatenating
Summary: [Enhancement] Update CGAffineTransform Multiply method to match native naming...
Status: CONFIRMED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 11.4 (d15-5)
Hardware: Macintosh Windows
: Normal enhancement
Target Milestone: Future Cycle (TBD)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-10-24 18:49 UTC by John Miller [MSFT]
Modified: 2017-10-25 08:40 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 60355 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description John Miller [MSFT] 2017-10-24 18:49:17 UTC
## Overview

The native CGAffineTransform has a "concatenating" method[1] while the Xamarin.iOS CGAffineTransform uses the name "Multiply".

It's preferable that the names of the Xamarin.iOS methods match the native names so that documentation is easier to understand when working with Xamarin.iOS. 

[1] https://developer.apple.com/documentation/coregraphics/cgaffinetransform/1455996-concatenating
[2] https://developer.xamarin.com/api/member/CoreGraphics.CGAffineTransform.Multiply/p/CoreGraphics.CGAffineTransform/
Comment 1 Vincent Dondain [MSFT] 2017-10-24 20:00:44 UTC
We usually prefer .NET-like APIs over copying Apple blindly.

There are a lot of .NET APIs which use "Multiply".

I'd like other team members feedback before closing this. In any case this would be a breaking change the the impact of the change is very low.
Comment 2 Rolf Bjarne Kvinge [MSFT] 2017-10-25 08:33:19 UTC
In my math courses I never heard about "matrix concatenation", it was always "matrix multiplication", so I think "Multiply" is a much more logical name.

That said, I'm open to adding a "Concat" method that just calls "Multiply". That would also be backwards-compatible, since it's just a new method.
Comment 3 Rolf Bjarne Kvinge [MSFT] 2017-10-25 08:40:01 UTC
I wonder if this is something we can do with extensions once (if?) C# has support for "extension everywhere" (https://github.com/dotnet/csharplang/issues/192)