Bug 60048 - Investigate using Ward annotations in the log profiler
Summary: Investigate using Ward annotations in the log profiler
Status: RESOLVED INVALID
Alias: None
Product: Runtime
Classification: Mono
Component: Profiler ()
Version: unspecified
Hardware: All All
: Normal enhancement
Target Milestone: Future Cycle (TBD)
Assignee: Alex Rønne Petersen
URL:
Depends on:
Blocks:
 
Reported: 2017-10-08 23:57 UTC by Alex Rønne Petersen
Modified: 2017-12-06 15:44 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED INVALID

Description Alex Rønne Petersen 2017-10-08 23:57:00 UTC
It would be nice to try and use Ward [0] annotations to catch violations of various invariants in the log profiler.

A few examples:

* We shouldn't try to write an event to a log buffer without holding the reader or exclusive lock.
* We shouldn't start writing a new event to a log buffer if we're already writing one.
* We shouldn't try to iterate the thread list without holding the exclusive lock.
* We shouldn't try to acquire the reader or exclusive lock recursively.
* We shouldn't use signal-unsafe functions in the sample hit callback.

[0] https://github.com/evincarofautumn/Ward
Comment 1 Alex Rønne Petersen 2017-12-06 15:44:30 UTC
Moving to GitHub: https://github.com/mono/mono/issues/6182