Bug 59164 - Confirm* interface methods should probably be bound as ConfirmCan*, instead
Summary: Confirm* interface methods should probably be bound as ConfirmCan*, instead
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 10.99 (xcode9)
Hardware: PC Mac OS
: Normal minor
Target Milestone: Xcode9
Assignee: Alex Soto [MSFT]
URL:
Depends on:
Blocks:
 
Reported: 2017-08-31 23:03 UTC by Mike Norman
Modified: 2017-09-05 12:40 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mike Norman 2017-08-31 23:03:27 UTC
For example, INActivateCarSignalIntentHandling_Extensions.ConfirmActivateCarSignal actually checks whether the signals can be activated, and not whether they have been activated.

I believe this is true across the namespace, but it may be necessary to go case by case.
Comment 1 Mike Norman 2017-08-31 23:14:01 UTC
On further review, this may not be the case at all. INPayBillIntentHandling_Extensions.ConfirmPayBill confirms details with the user, which leads me to believe that, in general, it is not a capability that is being confirmed, but permission and/or details.
Comment 2 Vincent Dondain [MSFT] 2017-08-31 23:29:57 UTC
Well I have the simple solution to this:

`INActivateCarSignalIntentHandling.Confirm` (:

_Which turns out to also be the name of the Swift version._

Let's review them all, `ConfirmPayBill` in Swift is also `Confirm`.
Comment 3 Sebastien Pouliot 2017-09-01 18:17:02 UTC
Some of those are not new API in xcode9 (e.g. `ConfirmPayBill`) and cannot be changed without breaking API.

@Alex please double check the new API to see if Vincent's suggestion can be applied. Thanks!
Comment 4 Alex Soto [MSFT] 2017-09-05 12:37:06 UTC
In Progress -> https://github.com/xamarin/xamarin-macios/pull/2591
Comment 5 Alex Soto [MSFT] 2017-09-05 12:40:29 UTC
Fixed in xamarin-macios/xcode9 @ 17a7b1c386572788dba119bc18414f2c31afad62