Bug 59085 - [introspection-ios] selector not found for UIKit.UIBarButtonItem : setSpringLoaded: - Broken test
Summary: [introspection-ios] selector not found for UIKit.UIBarButtonItem : setSpringL...
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Infrastructure (internal) ()
Version: XI 10.99 (xcode9)
Hardware: PC Mac OS
: Normal normal
Target Milestone: Xcode9
Assignee: Vincent Dondain [MSFT]
URL:
Depends on:
Blocks:
 
Reported: 2017-08-28 19:08 UTC by Vincent Dondain [MSFT]
Modified: 2017-08-28 21:18 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Vincent Dondain [MSFT] 2017-08-28 19:08:24 UTC
`SkipDueToAttributeInProperty` which is used to check the availability attribute of properties when the Availability info only exist on the property and not on the property Getter or Setter is wrong. This leads to `setSpringLoaded` (which was introduced in iOS 11) to not be ignored by the test (making it fail).

We are returning false here: https://github.com/xamarin/xamarin-macios/blob/master/tests/introspection/ApiBaseTest.cs#L177

Also we're only doing `p => p.GetGetMethod () == m` when we should be doing `p => p.GetGetMethod () == m || p => p.GetSetMethod () == m`.

I already have a fix for this locally, PR incoming.
Comment 2 Vincent Dondain [MSFT] 2017-08-28 19:16:22 UTC
PR: https://github.com/xamarin/xamarin-macios/pull/2557
Comment 3 Vincent Dondain [MSFT] 2017-08-28 21:18:49 UTC
PR has been merged.