Bug 59078 - StoreProductParameters and invalid property for CampaignToken
Summary: StoreProductParameters and invalid property for CampaignToken
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 10.99 (xcode9)
Hardware: PC Mac OS
: Normal normal
Target Milestone: Future Cycle (TBD)
Assignee: Vincent Dondain [MSFT]
URL:
Depends on:
Blocks:
 
Reported: 2017-08-28 08:27 UTC by Songtive Team
Modified: 2017-08-29 19:30 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Songtive Team 2017-08-28 08:27:27 UTC
Hi,

I've just noticed that StoreProductParameters.AffiliateToken and StoreProductParameters.CampaignToken refer to the same key:

        public string CampaignToken {
            get {
                return base.GetStringValue (SKStoreProductParameterKey.AffiliateToken);
            }
            set {
                base.SetStringValue (SKStoreProductParameterKey.AffiliateToken, value);
            }
        }

it should 

        public string CampaignToken {
            get {
                return base.GetStringValue (SKStoreProductParameterKey.CampaignToken);
            }
            set {
                base.SetStringValue (SKStoreProductParameterKey.CampaignToken, value);
            }
        }
Comment 1 Vincent Dondain [MSFT] 2017-08-28 20:00:18 UTC
Well you did almost all the work here (:

Thanks for that bug report, it's indeed a typo which is easy to fix, here's the pull-request: https://github.com/xamarin/xamarin-macios/pull/2559

This will be included in a future release.
Comment 2 Vincent Dondain [MSFT] 2017-08-29 19:30:46 UTC
PR merged to master and back ported to xcode9 branch: https://github.com/xamarin/xamarin-macios/pull/2560