Bug 58966 - [Android] EntryEditText and EditorEditText have been removed which is a breaking change
Summary: [Android] EntryEditText and EditorEditText have been removed which is a break...
Status: RESOLVED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 2.4.0
Hardware: PC Windows
: Normal normal
Target Milestone: 2.4.0
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-08-23 06:34 UTC by Michael Rumpler
Modified: 2017-08-24 19:59 UTC (History)
3 users (show)

Tags: ac fr
Is this bug a regression?: ---
Last known good build:


Attachments
sample project (3.61 MB, application/x-zip-compressed)
2017-08-23 06:34 UTC, Michael Rumpler
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Michael Rumpler 2017-08-23 06:34:03 UTC
Created attachment 24356 [details]
sample project

With PR 927 the classes Xamarin.Forms.Platform.Andorid.EntryEditText and EditorEditText have been replaced by FormsEditText. The old classes have been removed. Unfortunately this is a breaking change. Every dll which uses the old EntryRenderer which inherited from ViewRenderer<Entry, EntryEditText> will have to be recompiled with the new EntryRenderer which inherits from ViewRenderer<Entry, FormsEditText>. The same goes for the EditorRenderer.

The attached sample project is from the component DevExpress Grid. I upgraded it to XF 2.4.0.266-pre1. It crashes on start with a TypeLoadException: Could not resolve type with token 010000d5 (from typeref, class/assembly Xamarin.Forms.Platform.Android.EditorEditText, Xamarin.Forms.Platform.Android, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null)
Comment 1 Michael Rumpler 2017-08-24 06:11:25 UTC
This will be fixed by https://github.com/xamarin/Xamarin.Forms/pull/1114 (already merged).
Comment 2 Samantha Houts [MSFT] 2017-08-24 19:59:30 UTC
Should be fixed in 2.4.0-pre2. Thank you!