Bug 586 - [PATCH] potential crash in ToolStripItem.HandleClick()
Summary: [PATCH] potential crash in ToolStripItem.HandleClick()
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: Windows.Forms ()
Version: 2.10.x
Hardware: PC Linux
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2011-09-01 11:07 UTC by Stephen McConnel
Modified: 2011-10-17 06:23 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
ToolStrip-HandleClick-Bug.tgz contains a simplified test program that exposes the crashing bug. It also contains a proposed patch. (7.21 KB, application/x-compressed-tar)
2011-09-01 11:07 UTC, Stephen McConnel
Details
Here is a proposed patch. (625 bytes, patch)
2011-09-01 11:10 UTC, Stephen McConnel
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Stephen McConnel 2011-09-01 11:07:42 UTC
Created attachment 229 [details]
ToolStrip-HandleClick-Bug.tgz contains a simplified test program that exposes the crashing bug.  It also contains a proposed patch.

The HandleClick method in ToolStripItem does not check for Parent being null (unlike most methods in that class).  This is causing crashes in a program that I'm helping to develop.  It does not crash on Windows using the standard Microsoft .net libraries.
Comment 1 Stephen McConnel 2011-09-01 11:10:11 UTC
Created attachment 230 [details]
Here is a proposed patch.
Comment 2 Stephen McConnel 2011-09-01 11:11:58 UTC
The test case was built in MonoDevelop 2.4.
The test case archive does not contain the patch, contrary to my original comment.
Comment 3 Stephen McConnel 2011-09-14 12:15:57 UTC
This bug affects both the 2.8 and 2.10 branches.
Comment 4 Tom Hindle 2011-10-17 06:23:48 UTC
commit d936d6f94f9f42a8032059a2acbd147b99af9a09