Bug 58349 - [xcode9][coreimage] Fix CIImageAccumulator initializers
Summary: [xcode9][coreimage] Fix CIImageAccumulator initializers
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 10.99 (xcode9)
Hardware: PC Mac OS
: --- normal
Target Milestone: Xcode9
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2017-07-25 03:18 UTC by Sebastien Pouliot
Modified: 2017-08-03 14:15 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Sebastien Pouliot 2017-07-25 03:18:52 UTC
Commit "[coreimage] CIImageAccumulator init returns nil in beta 4" [1] enable (public) some API that were only (half exposed) in XM and might not be correct (or could be better).

The origin for this needs to be found (before open sourcing).

[1] b0816bb0d1df97de661202ff13f255efb4a95560
Comment 1 Sebastien Pouliot 2017-08-03 00:25:22 UTC
Old XM only API added, likely before CIFormat was added, more than 6 years ago in
https://github.com/xamarin/maccore/blame/ba8c11195eb76df357e524486cbf43db50ee4adf/src/coreimage.cs

They were hidden (good) when CIImageAccumulator was added in iOS9, but correct ones were not provided (bad)
https://github.com/xamarin/maccore/commit/2724935702799e39670a6616c00713cd8af80230

PR https://github.com/xamarin/xamarin-macios/pull/2412 obsolete the "bad" and provide better (CIFormat based) overloads.