Bug 58295 - xamarin-macios does not build with mono 5.4
Summary: xamarin-macios does not build with mono 5.4
Status: RESOLVED FIXED
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: Library (Xamarin.Mac.dll) ()
Version: Master
Hardware: PC Mac OS
: High major
Target Milestone: master
Assignee: Chris Hamons
URL:
Depends on:
Blocks:
 
Reported: 2017-07-21 14:21 UTC by Chris Hamons
Modified: 2017-07-31 21:22 UTC (History)
6 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Chris Hamons 2017-07-21 14:21:44 UTC
/cvs/mt/xamarin-macios/src/AudioUnit/AudioUnit.cs(1723,19): error CS1629: Unsafe code may not appear in iterators

TIL: https://blogs.msdn.microsoft.com/ericlippert/2009/07/27/iterator-blocks-part-six-why-no-unsafe-code

The code in question may have to be rewritten.
Comment 1 Rolf Bjarne Kvinge [MSFT] 2017-07-31 11:31:36 UTC
https://github.com/xamarin/xamarin-macios/commit/cbb45f65b5ae226ac2ddf8dba102f3e12b6c496e

That's in the mono-2017-06 branch, maybe we should put that in master too.
Comment 2 Chris Hamons 2017-07-31 13:55:15 UTC
Looks safe enough. I'm fine with an early cherry pick if people want, though just telling people to install a known-good system mono is more likely to locally produce good results.
Comment 3 Sebastien Pouliot 2017-07-31 18:52:22 UTC
Let's put it (and similar stuff) into master and keep the `mono-2017-06` as minimal as possible (e.g. stuff that can't work with 2017-04).
Comment 4 Chris Hamons 2017-07-31 20:09:11 UTC
https://github.com/xamarin/xamarin-macios/pull/2386
Comment 5 Chris Hamons 2017-07-31 21:22:06 UTC
Landed in master.