Bug 57764 - __IOS__ is defined for tvOS and watchOS binding projects
Summary: __IOS__ is defined for tvOS and watchOS binding projects
Status: VERIFIED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: MSBuild ()
Version: master
Hardware: PC Mac OS
: --- normal
Target Milestone: 15.4
Assignee: Jeffrey Stedfast
URL:
Depends on:
Blocks:
 
Reported: 2017-06-26 15:45 UTC by Rolf Bjarne Kvinge [MSFT]
Modified: 2017-07-27 10:43 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: No
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Rolf Bjarne Kvinge [MSFT] 2017-06-26 15:45:42 UTC
Test case:

* Cherry-pick https://github.com/rolfbjarne/xamarin-macios/commit/33386e32b7b200369dab87e3f3a23bc10ce9890d
* cd tests && make build-sim-monotouch-test

/work/maccore/master/xamarin-macios/tests/common/ConditionalCompilation.cs(5,8): error CS1029: #error: '__TVOS__ should not be defined when __IOS__ is defined'
/work/maccore/master/xamarin-macios/tests/common/ConditionalCompilation.cs(23,8): error CS1029: #error: '__IOS__ should not be defined when __TVOS__ is defined'

__IOS__ is not defined for normal tvOS and watchOS projects, only binding projects.
Comment 1 Jeffrey Stedfast 2017-06-29 18:29:17 UTC
PR: https://github.com/xamarin/xamarin-macios/pull/2274
Comment 2 Rolf Bjarne Kvinge [MSFT] 2017-07-03 12:41:39 UTC
fixed (master): https://github.com/xamarin/xamarin-macios/commit/6351aef095493d2c8754d317cd6905fc06578c11