Bug 57612 - Support managed allocators when profiling
Summary: Support managed allocators when profiling
Status: RESOLVED FIXED
Alias: None
Product: Runtime
Classification: Mono
Component: Profiler ()
Version: master
Hardware: All All
: Normal normal
Target Milestone: Future Cycle (TBD)
Assignee: Alex Rønne Petersen
URL:
Depends on:
Blocks:
 
Reported: 2017-06-20 05:18 UTC by Alex Rønne Petersen
Modified: 2017-07-07 00:42 UTC (History)
0 users

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Alex Rønne Petersen 2017-06-20 05:18:25 UTC
When profiling is enabled, we should instrument managed allocators with a check like this:

	if (G_UNLIKELY (mono_profiler_events & MONO_PROFILE_ALLOCATIONS)) {
		mono_profiler_allocation (p);
	}

This of course slows down managed allocators a bit, but it's nothing compared to falling back to C code for all allocations.
Comment 1 Alex Rønne Petersen 2017-07-07 00:42:30 UTC
https://github.com/mono/mono/pull/5101