Bug 5726 - Override completion no longer works for interface members
Summary: Override completion no longer works for interface members
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: Trunk
Hardware: PC Mac OS
: Low enhancement
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2012-06-19 00:51 UTC by Mikayla Hutchinson [MSFT]
Modified: 2012-10-01 03:39 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mikayla Hutchinson [MSFT] 2012-06-19 00:51:30 UTC
Override completion no longer works for unimplemented interface member.
Comment 1 Miguel de Icaza [MSFT] 2012-09-28 12:00:19 UTC
It has always seemed strange to me that typing "override" would offer a completion from the interface, since it is effectively a "magic" word that actually means "suggest an interface member, but remove the word override when the user selects".

This does not sound right to me.

It is almost as having turned a hotkey into the long string override.   I am not even sure that this is a bug, it requires some discussion/debate.
Comment 2 Mikayla Hutchinson [MSFT] 2012-09-28 14:16:56 UTC
It may not have been "technically correct", but it was very useful and didn't interfere with anything else.
Comment 3 Mike Krüger 2012-09-29 07:19:37 UTC
Hm, I think it may be better in the generate code window (we should've a hotkey for that).

I think too that it was very strange - at least my workflow when implementing an interface is: right click on the interface name and select implement.
Comment 4 Miguel de Icaza [MSFT] 2012-09-29 12:53:28 UTC
What about adding this to the completion window, so when I do control-space, implementing methods that are missing from an interface are offered?

That sounds natural to me.
Comment 5 Mikayla Hutchinson [MSFT] 2012-09-29 16:28:11 UTC
The generate window would make sense. We still need a keybinding for that on Mac.

Putting it in the toplevel completion window would be weird, we'd have to have the full signature in there, matching would be a bitt odd because of the spaces, and the sort position would mostly be controlled by the return type.
Comment 6 Mike Krüger 2012-10-01 03:39:20 UTC
Implemented (including the mac key binding)

I think that makes the most sense - we should make this feature more prominent. I whish we had IDEA like tip of the days :)