Bug 56945 - macOS: Button's text alignment does not work when setting colors.
Summary: macOS: Button's text alignment does not work when setting colors.
Status: RESOLVED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Rui Marinho
URL:
Depends on:
Blocks:
 
Reported: 2017-05-29 18:56 UTC by Brad Chase
Modified: 2017-05-30 09:37 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Brad Chase 2017-05-29 18:56:12 UTC
The issue is when using attributed titles the layout uses NSMutableAttributedString instead of the default control alignment.

I have a fix I will put up shortly.  I am putting one up for the Button but this should affect LabelRenderer and other areas where attributed titles are used.  There might be other issues as well as not just horizontal layouts...
Comment 1 Brad Chase 2017-05-29 19:16:49 UTC
After looking through the rest of the code, it appears only the SearchBarRenderer is using the AttributedTitle at line 143, SearchBarRenderer.cs.

So there might not be any other controls with issues.  That does leave some questions about what else is being set but not used for the button.
Comment 2 Brad Chase 2017-05-29 19:24:28 UTC
Linkback to the PR for discussion

https://github.com/xamarin/Xamarin.Forms/pull/942
Comment 3 Rui Marinho 2017-05-30 09:37:48 UTC
Should be fixes on 2.3.6-pre1