Bug 56682 - Denying Assembly load of Facades forced ugly hack in XM in 15.2.2, needs real solution for 15.3
Summary: Denying Assembly load of Facades forced ugly hack in XM in 15.2.2, needs real...
Status: VERIFIED FIXED
Alias: None
Product: Tools
Classification: Mono
Component: msbuild ()
Version: unspecified
Hardware: PC Mac OS
: High major
Target Milestone: ---
Assignee: Ankit Jain
URL:
Depends on:
Blocks:
 
Reported: 2017-05-19 19:40 UTC by Chris Hamons
Modified: 2017-09-28 09:30 UTC (History)
9 users (show)

Tags:
Is this bug a regression?: Yes
Last known good build: 15.2.2 rc1 3.4.0.36


Attachments
System.Text.Encoding error (373.21 KB, image/png)
2017-09-08 16:45 UTC, GouriKumari
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Chris Hamons 2017-05-19 19:40:22 UTC
We are going to land this in 15.2.2:

https://github.com/xamarin/xamarin-macios/pull/2108

but it is a total hack.

We need a real solution to:

https://bugzilla.xamarin.com/show_bug.cgi?id=55988

coming from somewhere lower on the stack.
Comment 2 Chris Hamons 2017-07-06 21:46:54 UTC
Marek / Ankit - I guess/believe this was fixed differently in 15.3, can someone confirm / provide details?
Comment 4 Sebastien Pouliot 2017-08-28 23:58:44 UTC
PR merged in xamarin-macios/master

Backport for d15-4 -> https://github.com/xamarin/xamarin-macios/pull/2562
Comment 5 GouriKumari 2017-09-08 16:42:47 UTC
## Steps to reproduce:

Installed XM 3.4.0.33pkg and mono5.0.0.100 to reproduce the issue mentioned in bug 55988. Installed master build 3.9.0.71.pkg to verify fix.

## Observed Behaviour:
With fix from master build, System.ValueTuple loading is fixed. However, issue reported in https://bugzilla.xamarin.com/show_bug.cgi?id=56574 is reproducible.

##Test Env:
https://gist.github.com/GouriKumari/23e87f4c3b81b4fee96fc907abb43ce7
Comment 7 GouriKumari 2017-09-08 20:10:41 UTC
An update to this bug: Issue mentioned in bug 56574 is still reproducible with d15-3 stable and d15-4 alpha builds. It seems the hack included in 15.2.2 service release wasn't included in d15-3. 

## Supplemental Info:
Issue is fixed only in 15.2.2 service release
Build Log: https://gist.github.com/GouriKumari/75c7daed017a7b45796c3e27000a8077
Application Output: https://gist.github.com/GouriKumari/f3355f5b1fcc7b4983ebe490a3460858
Comment 8 Ankit Jain 2017-09-08 20:40:23 UTC
The earlier hack was removed. And a new hack/fix was added in https://github.com/mono/msbuild/commit/c907a5182a101624eb58e73fb24f97666abf477a .

Can you attach the diag build log with 15.4 and the test project that you used?
Comment 11 GouriKumari 2017-09-12 21:26:29 UTC
I tested with XM master build 3.9.0.81 and  I could reproduce the issue.

## Build Log: 
https://gist.githubusercontent.com/GouriKumari/50b137b42de61c0f8f815512bc1c517c/raw/707f9c8c822e5b5f258c237806bab16cd84cab44/gistfile1.txt

##Test Env:
https://gist.github.com/6cd561b1c06cca9b1869ba2b3363c6d0
Comment 12 GouriKumari 2017-09-13 22:13:47 UTC
Retested with XM master build 3.9.0.84. TestRosylnApp builds and launch successfully with Xamarin.Full config. 

## Logs:
Build Log: https://gist.githubusercontent.com/GouriKumari/685d4d8fb5a56818e92daa1785e16317/raw/04de255f266d541c61e2afd7474eace6f36f1208/gistfile1.txt

Application Output:
https://gist.github.com/GouriKumari/85e82486f7e133928ec6329ca073d5a5

## Test Env:
https://gist.github.com/d2d4c0551f2dc02d78a16d221666c8b1