Bug 56513 - Code sharing: allow identical assemblies from different paths
Summary: Code sharing: allow identical assemblies from different paths
Status: VERIFIED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Tools ()
Version: master
Hardware: PC Mac OS
: High enhancement
Target Milestone: 15.3
Assignee: Rolf Bjarne Kvinge [MSFT]
URL:
: 56742 ()
Depends on:
Blocks:
 
Reported: 2017-05-16 16:44 UTC by Rolf Bjarne Kvinge [MSFT]
Modified: 2017-07-20 10:07 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Rolf Bjarne Kvinge [MSFT] 2017-05-16 16:44:51 UTC
See bug #56498 for a test case.

Code sharing is always beneficial, so we should allow code sharing if assemblies are found in different paths, but a byte-by-byte comparison reveals they're in fact identical.
Comment 1 Rolf Bjarne Kvinge [MSFT] 2017-05-16 16:46:02 UTC
This sounds like something that would be nice to get in 15.3, so I'm setting milestone accordingly.
Comment 2 Rolf Bjarne Kvinge [MSFT] 2017-05-23 10:46:59 UTC
https://github.com/xamarin/xamarin-macios/pull/2119
Comment 3 Bill Holmes 2017-05-23 17:49:32 UTC
*** Bug 56742 has been marked as a duplicate of this bug. ***
Comment 5 kyle.spearrin 2017-05-25 12:56:55 UTC
@Rolf Will this be in 15.3?
Comment 6 Andy 2017-05-25 13:16:00 UTC
@kyle It is my understanding that because the change made it into master, it will be a part of the next Xamarin.iOS release which should be in a branch called d15-3. You can learn more here: https://github.com/xamarin/xamarin-macios/wiki
Comment 7 Rolf Bjarne Kvinge [MSFT] 2017-05-25 13:19:18 UTC
Yes, it will be in 15.3
Comment 8 Swati Gangrade 2017-07-20 09:00:55 UTC
To verify the bug I performed below steps :

1. Following bug-Bug 56742 I Downloaded a project: https://github.com/zippo227/ios-samples/tree/master/ios10/MessageCodeSharing
2. Launched VSFM
3. Opened project in VSFM
4. Build project
5. Observed the generated diagnostic logs

Actual Result- "Native code sharing has been disabled" is not displayed in the logs.

Is it the expected result? 

Diagnostic Build Logs Link- https://gist.github.com/gangrade-swati/c1cc6d4bedd70bce54c3ea8d73484ed6

@Rolf Bjarne Kvinge Can you please confirm about verification steps an actual result. If all is good then I moved it to Verified state
Comment 9 Rolf Bjarne Kvinge [MSFT] 2017-07-20 09:04:56 UTC
@Swati, yes, that looks good.
Comment 10 Swati Gangrade 2017-07-20 10:06:53 UTC
So actual result and expected results are matched so shall I marked bug as verified?
Comment 11 Rolf Bjarne Kvinge [MSFT] 2017-07-20 10:07:58 UTC
Yes, consider this verified.