Bug 54981 - Can't build profiler with msbuild (missing property in Exec task)
Summary: Can't build profiler with msbuild (missing property in Exec task)
Status: VERIFIED FIXED
Alias: None
Product: Tools
Classification: Mono
Component: msbuild ()
Version: unspecified
Hardware: PC Mac OS
: --- normal
Target Milestone: 15.2
Assignee: Ankit Jain
URL:
Depends on:
Blocks:
 
Reported: 2017-04-10 17:23 UTC by Rodrigo Moya
Modified: 2017-05-11 11:42 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Comment 1 Ankit Jain 2017-04-15 08:04:41 UTC
Fixed for command line: https://github.com/mono/msbuild/commit/31480424881941ea21d6551e5e332c7467855999
Comment 2 Ankit Jain 2017-04-19 22:52:29 UTC
Fix for XS: https://github.com/mono/monodevelop/pull/2223

This PR fixes the particular reported issue with XS. But clean build from XS still fails because it doesn't seem to be able to restore `MSBuilder.CodeTaskAssembly` nuget. Also, XS restores in a different directory than the command line. So, @Rodrigo, did this project build with XS at all?
Comment 3 Ankit Jain 2017-04-19 23:29:15 UTC
Opened https://bugzilla.xamarin.com/show_bug.cgi?id=55415 to track the separate  build issue.
Comment 4 Rodrigo Moya 2017-04-20 07:55:29 UTC
It was (and still is) building correctly on XS, as, AFAIK, XS uses xbuild, and our Makefile we still are using xbuild.

It failed (and still does) using msbuild in the Makefile or building it in VSfM, which, AFAIK, uses msbuild by default, right?
Comment 5 Ankit Jain 2017-04-20 15:55:35 UTC
PR https://github.com/mono/monodevelop/pull/2225 merged.
Comment 6 Alok Kulkarni 2017-05-09 09:05:16 UTC
Hi @Rodrigo Moya, It will be great if you can provide the steps to verify this bug or will you please verify this.?
Comment 7 Rodrigo Moya 2017-05-11 11:42:50 UTC
Only way to verify it is by building the source code yourself, but since the profiler is now being built correctly with msbuild on Wrench, we can mark this as verified