Bug 54793 - Bug in SessionStateModule when session data is deleted
Summary: Bug in SessionStateModule when session data is deleted
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: System ()
Version: unspecified
Hardware: PC All
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-04-07 18:19 UTC by José Manuel
Modified: 2017-09-08 23:16 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description José Manuel 2017-04-07 18:19:29 UTC
-------------------------------
- Title
-------------------------------
Fix bug in SessionStateModule (namespace: System.Web.SessionState) when session data is deleted

-------------------------------
- Description
-------------------------------

When the Session.Abandon() method is called, the session data is not deleted. I am using the Microsoft.Web.RedisSessionStateProvider provider.

The flow is as follows:
* In action controller I call the Session.Abandon() method
* In SessionStateModule class:
  * The property IsAbandoned is checked as true
  * When OnReleaseRequestState is called then session items will be deleted

The problem is that the call to release is made before deleting resources.

I have been reviewing the Microsoft documentation about the same class and it does not call the release method.(https://referencesource.microsoft.com/#System.Web/State/SessionStateModule.cs,70c779c55ecdc3d7,references)

-------------------------------
- Web.config session section
-------------------------------

<sessionState mode="Custom" customProvider="SessionStateRedis">
      <providers>
        	<add name="SessionStateRedis"
             	  type="Microsoft.Web.Redis.RedisSessionStateProvider"
             	  connectionString="session-state-redis"/>
      </providers>
</sessionState>
Comment 1 José Manuel 2017-04-07 18:35:49 UTC
Pull request: https://github.com/mono/mono/pull/4665