Bug 54784 - Mono for Windows (x86) License Agreement text not encoded correctly
Summary: Mono for Windows (x86) License Agreement text not encoded correctly
Status: RESOLVED FIXED
Alias: None
Product: Installers
Classification: Mono
Component: Windows Installer ()
Version: 4.8.0 (C9)
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Jo Shields
URL:
Depends on:
Blocks:
 
Reported: 2017-04-07 16:45 UTC by mledan
Modified: 2018-01-02 13:54 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Screencap of installer license agreement w/ incorrect encoding (26.10 KB, image/png)
2017-04-07 16:45 UTC, mledan
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description mledan 2017-04-07 16:45:04 UTC
Created attachment 21337 [details]
Screencap of installer license agreement w/ incorrect encoding

Running installer shows incorrect format for the text. I am able to copy and paste the content into another program, in this case Microsoft word and the plain text can be read correctly.

This leads me to believe the encoding in the license agreement viewer is not set correctly
Comment 1 Rodrigo Kumpera 2017-04-21 22:11:23 UTC
Hey Jo,

Can you take a look at this one?
Comment 2 Jo Shields 2017-04-24 11:50:35 UTC
Hi

Which encoding are you using for your system OS, which version of Windows, and does https://raw.githubusercontent.com/mono/release/master/resources/setup-files/license.rtf load okay in Wordpad? (you'll want to right-click save-as)
Comment 3 Jo Shields 2017-04-24 12:12:40 UTC
I have a hunch what the problem is, and I'm doing a test build of the installer containing a hypothetical fix.
Comment 4 Jo Shields 2017-04-24 13:16:49 UTC
Can you see if you still have a problem with http://xamjenkinsartifact.blob.core.windows.net/zzv/144/resources/bin/Release/MonoForWindows-x86.msi ?
Comment 5 mledan 2017-04-24 14:16:57 UTC
Still looking the same as my screencap on my end, unfortunately
Comment 6 mledan 2017-04-24 14:58:22 UTC
Just did a bit of digging around, apparently what's being displayed in your License Agreement is a font called PAXAR Care Symbol. Not sure if that'll help at all. Is it possible you are using a custom font that is being replaced by PAXAR on my system?
Comment 7 Jo Shields 2017-04-24 15:01:16 UTC
(In reply to mledan from comment #6)
> Just did a bit of digging around, apparently what's being displayed in your
> License Agreement is a font called PAXAR Care Symbol. Not sure if that'll
> help at all. Is it possible you are using a custom font that is being
> replaced by PAXAR on my system?

With the old build, I'd have said yes - the license RTF was specifying Helvetica (since it was produced on a Mac), which you wouldn't have, and it could have been falling back to something completely inappropriate. But my rebuild in comment 4 specifies Arial. Which should obviously be available & never fall back to anything.
Comment 8 Jo Shields 2017-04-24 15:04:10 UTC
A similar issue: https://musescore.org/en/node/51841
Comment 9 Alexander Köplinger [MSFT] 2018-01-02 13:54:10 UTC
Given that we changed the font to Arial in https://github.com/mono/release/commit/5ebfdf8821fc7bc21b133666596ddc3232811f17 and we can't reproduce the issue on our end I'll close this for now. Please reopen the issue on https://github.com/mono/mono/issues if you still see it, thanks.