Bug 54776 - ViewDidDisappear breaking change not documented
Summary: ViewDidDisappear breaking change not documented
Status: RESOLVED ANSWERED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 2.3.4
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-04-07 14:30 UTC by Chase Long
Modified: 2017-04-07 14:47 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED ANSWERED

Description Chase Long 2017-04-07 14:30:12 UTC
Xamarin.Forms version 2.3.4 introduces a breaking change involving MonoTouch.UIKit.UIViewController.ViewDidDisappear. https://releases.xamarin.com/stable-release-xamarin-forms-2-3-4-224/

> Behavior Change (iOS): ViewDidDisappear may not be reliably called in custom renderers. Please be sure to override Dispose to do any object cleanup that you may be doing in ViewDidDisappear to prevent any possible memory leaks in your custom renderers.

This behavior is missing from the API documentation. This behavior should noted somewhere other than the release notes. I think adding it directly to the MonoTouch.UIKit.UIViewController.ViewDidDisappear documentation would be reasonable, even though this is specific to Xamarin.Forms, since MonoTouch and Xamarin.Forms belong to the same family of products.
Comment 1 Paul DiPietro [MSFT] 2017-04-07 14:47:56 UTC
The docs are not necessarily 100% up to date when a package is released. I'd also suggest that for situations like this (minor docs issues that pertain to a newly released version), posting about it in the release thread on the forums will quite frankly get more attention on the issue.