Bug 54046 - `--sdkroot` is not being passed to the remoted sim
Summary: `--sdkroot` is not being passed to the remoted sim
Status: VERIFIED FIXED
Alias: None
Product: Visual Studio Extensions
Classification: Xamarin
Component: iOS ()
Version: 4.3.0 (C9)
Hardware: PC Mac OS
: Normal normal
Target Milestone: 15.3
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-03-27 13:39 UTC by Alan McGovern
Modified: 2017-07-10 12:50 UTC (History)
10 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Alan McGovern 2017-03-27 13:39:18 UTC
XVS must pass the `--sdkroot` parameter to the remoted simulator so we can propagate it to mlaunch. I believe this could be the root cause of several of the blocking bugs currently filed against the sim and/or XVS.

These are the arguments we currently receive:
arguments: --device=E2303CD7-5DDF-483C-9AB7-090AA691FA12 --launchsim=//Users/globallogic/Library/Caches/Xamarin/mtbs/builds/CrossPlat.iOS/472bcb86f0af668a65edb1b9d0e91e51/bin/iPhoneSimulator/Debug/CrossPlat.iOS.app -argument=-monodevelop-port -argument=59540 -setenv=__XAMARIN_DEBUG_PORT__=59540 -h=172.18.41.139 -ssh=Globallogic 

It's missing --sdkroot which tells mlaunch which xcode.app to use.
Comment 1 Alan McGovern 2017-04-03 12:51:19 UTC
Just upgraded the importance to make sure we address this while we're at the start of the 15.2 release cycle.
Comment 2 Alan McGovern 2017-04-03 12:51:57 UTC
As part of this we should review other parameters to make sure xvs is treating the remoted sim and normal sim identically.
Comment 3 Eric Maupin 2017-04-03 14:33:42 UTC

*** This bug has been marked as a duplicate of bug 44705 ***
Comment 4 Alan McGovern 2017-04-03 15:11:36 UTC
Did you close this because of the workaround we added, or because XVS is now passing the correct parameter?
Comment 5 Eric Maupin 2017-04-03 15:55:44 UTC
Because I misread it as we weren't passing sdkroot to mlaunch. However I'm downgrading the priority. We read XVS' value and pass it to mlaunch ourselves, it's not a blocker for them to add it as it will make no actual difference.
Comment 6 xamarin-release-manager 2017-05-22 19:24:37 UTC
Fixed in version 4.6.0.119 (master)

Author: Emanuel
Commit: cbba64b1e8c47dd6675d44a1eca8cee213d4ba6c (xamarin/XamarinVS)