Bug 52939 - Forms integration does not consider modal stack, only navigation stack
Summary: Forms integration does not consider modal stack, only navigation stack
Status: VERIFIED FIXED
Alias: None
Product: Workbooks & Inspector
Classification: Xamarin
Component: Xamarin.Forms Integration ()
Version: master
Hardware: All All
: Normal normal
Target Milestone: 15.1
Assignee: xamarininteractive
URL:
Depends on:
Blocks:
 
Reported: 2017-03-01 19:14 UTC by Bojan Rajkovic [MSFT]
Modified: 2017-03-22 07:08 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Reproduction project (52.10 KB, application/octet-stream)
2017-03-17 15:03 UTC, Bojan Rajkovic [MSFT]
Details
Logs and Screenshot (1.60 MB, application/zip)
2017-03-21 07:53 UTC, Alok Kulkarni
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Bojan Rajkovic [MSFT] 2017-03-01 19:14:13 UTC
See https://forums.xamarin.com/discussion/comment/256233.

We only look at the navigation stack when building the tree. We need to also include the modal stack.
Comment 1 Bojan Rajkovic [MSFT] 2017-03-02 16:01:17 UTC
This is fixed for 1.2/15.1.
Comment 2 Prasad Raghorte 2017-03-17 14:49:49 UTC
To verify this fix we require the exact steps to reproduce and screencast. Please provide this for further verification process.
Comment 3 Bojan Rajkovic [MSFT] 2017-03-17 15:03:30 UTC
Created attachment 20436 [details]
Reproduction project

Reproduction steps:

1. Open attached project
2. Build it
3. Run it
4. Click the "Click Me" button
5. Inspect the app and switch to the View Inspector tab

With versions of Inspector/Workbooks prior to 1.2/15.1, you will only see the "Click Me" button in the View Inspector tab, and the tree on the left will only show the single ContentPage. 

With 1.2/15.1, you will see both the "Click Me" button and the modal "Hello, Forms!" page, and both will appear in the tree on the left.
Comment 4 Alok Kulkarni 2017-03-21 07:53:22 UTC
Created attachment 20485 [details]
Logs and Screenshot

Verified on Xamarin Workbook/Inspector Version 1.2.0