Bug 52774 - debugger-libs should not use system nunit
Summary: debugger-libs should not use system nunit
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: General ()
Version: master
Hardware: PC Mac OS
: --- major
Target Milestone: Untriaged
Assignee: Alexander Köplinger [MSFT]
URL:
: 52773 ()
Depends on:
Blocks:
 
Reported: 2017-02-24 22:24 UTC by Andi McClure
Modified: 2017-02-27 19:55 UTC (History)
2 users (show)

Tags: 2017-02
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Andi McClure 2017-02-24 22:24:30 UTC
Monodroid builds

https://github.com/mono/debugger-libs

...because it builds sdb as a submodule. It runs

xbuild  /nologo /property:Configuration=net_4_0_Debug /verbosity:quiet debugger-libs.sln

This results in the error

[4:06:29] SdbEvaluationTests.cs(35,3): error CS0619: 'TestFixtureAttribute' is obsolete: 'The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'
[4:06:29] SdbStackFrameTests.cs(35,3): error CS0619: 'TestFixtureAttribute' is obsolete: 'The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'

The code it does not like is

	[TestFixture()]
	public class SdbEvaluationTests: EvaluationTests

As I understand, the project should be set up to use nuget instead of system nunit. Mareks believes this is easy to fix.
Comment 1 Andi McClure 2017-02-24 22:25:07 UTC
This is blocking integration of monodroid with 2017-02 master
Comment 2 Marek Safar 2017-02-24 22:59:40 UTC
*** Bug 52773 has been marked as a duplicate of this bug. ***
Comment 3 Alexander Köplinger [MSFT] 2017-02-27 19:48:12 UTC
https://github.com/mono/debugger-libs/pull/100 (talked to dkarlas on Slack, he'll review/merge).

Depending on how this repo is built from upstream you might need to add a "nuget restore" step in there before xbuild.

We could also make this better by adding a target that only builds debugger-libs but not the tests.
Comment 4 Alexander Köplinger [MSFT] 2017-02-27 19:55:45 UTC
Merged.