Bug 51867 - [Xamarin-Inspector]:Accessibility: MAS 17 :Windows: Color Contrast : Contrast Ratio of Title of pop-up Title having less than Required 4.5:1.
Summary: [Xamarin-Inspector]:Accessibility: MAS 17 :Windows: Color Contrast : Contrast...
Status: CLOSED FIXED
Alias: None
Product: Workbooks & Inspector
Classification: Xamarin
Component: Accessibility ()
Version: master
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bojan Rajkovic [MSFT]
URL:
Depends on:
Blocks:
 
Reported: 2017-01-28 03:08 UTC by Naveen Katakam
Modified: 2018-03-30 11:26 UTC (History)
2 users (show)

Tags: accessibility, wipro, xamarin-inspector, a11ymas, mas17
Is this bug a regression?: ---
Last known good build:


Attachments
Repro Screenshot. (291.53 KB, image/png)
2017-01-28 03:08 UTC, Naveen Katakam
Details
Preferences window (12.86 KB, image/png)
2017-09-27 06:22 UTC, Ramya Sri Narasinga
Details
color contrast -not fixed (88.92 KB, image/png)
2018-01-29 08:39 UTC, Ramya Sri Narasinga
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
CLOSED FIXED

Description Naveen Katakam 2017-01-28 03:08:44 UTC
Created attachment 19557 [details]
Repro Screenshot.

Testing Environment:
   OS: 
      •	Windows 10.
      •	Version 1067.
      •	Build 14393.607.
   Visual Studio and Xamarin:
      •	VS 2017 RC Enterprise.
      •	Xamarin For VS 4.3.0.550.
      •	Xamarin Inspector 1.0

Pre -Requisites: Build and Deploy Xamarin Application into Android Emulator

Repro:
   
   1. Launch Xamarin inspector.
   2. Select Tools menu.
   3. Select Options and observe Title contrast

Actual Result:
 
   Luminosity contrast ratio is less than 4.5:1 for the text against the background.

Expected: 

   Luminosity contrast ratio is less than 4.5:1 for the text against the background.
	
User Impact:
User having low vision cannot see title of pop-up message.
Comment 1 Bojan Rajkovic [MSFT] 2017-05-22 17:27:00 UTC
Fixed in https://github.com/bojanrajkovic/inspector/commit/760a4621166fa81f3545c9d576277d0cd15c891c, not marking as RESOLVED FIXED until the branch merges.
Comment 2 Bojan Rajkovic [MSFT] 2017-09-15 13:57:29 UTC
This is fixed in 1.3.
Comment 3 Ramya Sri Narasinga 2017-09-27 06:22:56 UTC
Created attachment 24947 [details]
Preferences window
Comment 4 Ramya Sri Narasinga 2017-09-27 06:23:23 UTC
The issue continues to repro in the version 1.3.1 (1.3-release/cbc48dd). attached the screenshot
Comment 5 Bojan Rajkovic [MSFT] 2017-11-01 15:34:46 UTC
This did somehow get dropped between the original fix and the final release. Will re-fix.
Comment 6 Bojan Rajkovic [MSFT] 2017-11-30 17:04:02 UTC
Fixed in https://github.com/Microsoft/workbooks/pull/75.
Comment 7 Ramya Sri Narasinga 2018-01-29 08:39:16 UTC
Hi, the color contrast is still getting failed even in the latest version i:e version 1.4(master/b3f92f9). attached the screenshot as well.
Comment 8 Ramya Sri Narasinga 2018-01-29 08:39:40 UTC
Created attachment 26126 [details]
color contrast -not fixed
Comment 9 Bojan Rajkovic [MSFT] 2018-02-08 20:10:28 UTC
Hi,

The foreground is #000000 not #111111. It looks like you're seeing anti-aliasing artifacts captured by the color contrast analyzer.

You can see the brush color being set to black here: https://github.com/Microsoft/workbooks/blob/master/Clients/Xamarin.Interactive.Client.Windows/Themes/Light.xaml#L60 and that brush is used by the window to draw its title when it is not active, here: https://github.com/Microsoft/workbooks/blob/master/Clients/Xamarin.Interactive.Client.Windows/Resources.xaml#L340.
Comment 10 Ramya Sri Narasinga 2018-03-30 11:26:22 UTC
Closing this bug as the issue no more repros