Bug 51861 - [Xamarin-Inspector]:Accessibility: MAS 17 :Windows: Color Contrast : Contrast Ratio of 'Close,Minimise,Maxmize' buttons having less than Required 4.5:1.
Summary: [Xamarin-Inspector]:Accessibility: MAS 17 :Windows: Color Contrast : Contrast...
Status: CLOSED INVALID
Alias: None
Product: Workbooks & Inspector
Classification: Xamarin
Component: Accessibility ()
Version: master
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bojan Rajkovic [MSFT]
URL:
Depends on:
Blocks:
 
Reported: 2017-01-28 02:51 UTC by Naveen Katakam
Modified: 2017-11-01 05:03 UTC (History)
2 users (show)

Tags: accessibility, wipro, xamarin-inspector, a11ymas, mas17
Is this bug a regression?: ---
Last known good build:


Attachments
Repro Screenshot. (1.71 MB, application/x-zip-compressed)
2017-01-28 02:51 UTC, Naveen Katakam
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
CLOSED INVALID

Description Naveen Katakam 2017-01-28 02:51:56 UTC
Created attachment 19551 [details]
Repro Screenshot.

Testing Environment:
   OS: 
      •	Windows 10.
      •	Version 1067.
      •	Build 14393.607.
   Visual Studio and Xamarin:
      •	VS 2017 RC Enterprise.
      •	Xamarin For VS 4.3.0.550.
      •	Xamarin Inspector 1.0

Pre -Requisites: Build and Deploy Xamarin Application into Android Emulator

Repro:

   Scenario 1:

       1. Launch Xamarin Inspector.
       2. Observe Contrast Ratio of Close Minimize and Maximize buttons.

   Scenario 2:
       1. Launch Xamarin Inspector.
       2. Observe View inspector and REPL Buttons Contrast Ratio

   Scenario 3:
       1. Launch Xamarin Inspector.
       2. Arrive at Tools menu and Hit Enter.
       3. Select options and hit enter.
       4. Observe High Contrast of Increment/Decrement button (+/-).

   Scenario 4:
       1. Launch Xamarin inspector -> Click on View inspector button available in LHS Pane bottom.
       2. Observe contrast ratio of Categorize button and A-Z button.

Actual Result:

   Scenario-1:
       Luminosity contrast ratio is less than 4.5:1 for the text against the background.

   Scenario-2:
       Luminosity contrast ratio is less than 4.5:1 for the text against the 
       background.

   Scenario-3:
       Luminosity contrast ratio is less than 4.5:1 for the text against the background.

   Scenario-4:
       Luminosity contrast ratio is less than 4.5:1 for the text against the background.

Expected: 

   Scenario-1:
       Luminosity contrast ratio should be above 4.5:1 for all the text against the background.

   Scenario-2:
       Luminosity contrast ratio should be above 4.5:1 for all the text against the background.

   Scenario-3:
       Luminosity contrast ratio is less than 4.5:1 for the text against the background.

   Scenario-4:
       Luminosity contrast ratio is less than 4.5:1 for the text against the background.
	
User Impact:

User having low vision cannot see the Button Name so they will face challenges to understand that.
Comment 1 Bojan Rajkovic [MSFT] 2017-05-22 19:26:41 UTC
Just a note, scenario 4 here is specific to the Telerik controls, which are difficult to style.
Comment 2 Bojan Rajkovic [MSFT] 2017-05-22 20:48:34 UTC
Scenario 2 is fixed in https://github.com/xamarin/inspector/commit/2f0537e257e0e05b4bffb088ddcae22ffd7507a8.

Scenario 3 may be hard to fix—something is applying an 0.5 opacity to the Up/Down buttons in NumericUpDown, and it's neither our code nor MahApps—it appears to be something specific to WPF's RepeatButton.
Comment 3 Bojan Rajkovic [MSFT] 2017-05-23 14:27:15 UTC
Scenario 1 is fixed in https://github.com/bojanrajkovic/inspector/commit/ce0bcc02bc0e307f1d4f1488250c7b8e358e9698.
Comment 4 Bojan Rajkovic [MSFT] 2017-05-23 16:50:02 UTC
Scenario 3 lurks deep in the MahApps templates, in the ChromelessButtonTemplate, which has a trigger to set Opacity to 0.5 when it's not being hovered.

Looks like we'll have to build a custom widget if we want to keep the same numeric up/down style but get rid of the opacity changes?
Comment 5 Bojan Rajkovic [MSFT] 2017-09-15 13:56:26 UTC
This is fixed in 1.3 scenario 4 is part of the Telerik controls and is not fixed in 1.3, but should be a separate bug.
Comment 6 Ramya Sri Narasinga 2017-11-01 05:03:39 UTC
Since we check color contrast ratio only for text and this bug is been raised for text on buttons , this is an invalid bug