Bug 51814 - The profiler must be able to deal with events that exceed the fixed buffer size
Summary: The profiler must be able to deal with events that exceed the fixed buffer size
Status: RESOLVED FIXED
Alias: None
Product: Runtime
Classification: Mono
Component: Profiler ()
Version: master
Hardware: All All
: Normal normal
Target Milestone: Future Cycle (TBD)
Assignee: Alex Rønne Petersen
URL:
Depends on:
Blocks:
 
Reported: 2017-01-27 10:36 UTC by Alex Rønne Petersen
Modified: 2017-06-21 18:34 UTC (History)
0 users

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Alex Rønne Petersen 2017-01-27 10:36:12 UTC
Currently, the profiler will simply run into a buffer overflow if writing an event takes more than 64k of data. While this is unlikely to happen in practice, it would still be nice to have code in place to deal with it.
Comment 1 Alex Rønne Petersen 2017-06-18 19:17:01 UTC
Also, ensure_logbuf_unsafe () needs to be rewritten entirely. It checks for 100 more bytes than requested, which is just a hack that hides potential bugs. Further, a thread's log buffer is never NULL, so that check should go.
Comment 2 Alex Rønne Petersen 2017-06-20 04:41:29 UTC
https://github.com/mono/mono/pull/5072