Bug 51688 - NodeView.NodeStore setter not changing underlying field
Summary: NodeView.NodeStore setter not changing underlying field
Status: RESOLVED FIXED
Alias: None
Product: Gtk#
Classification: Mono
Component: gtk-sharp ()
Version: 2.x
Hardware: PC All
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-01-21 18:01 UTC by master-chi
Modified: 2018-02-28 19:46 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description master-chi 2017-01-21 18:01:21 UTC
NodeView.NodeStore property setter isn't setting "store" field so we can't change NodeStore.
https://github.com/mono/gtk-sharp/blob/gtk-sharp-2-12-branch/gtk/NodeView.cs#L53.

If NodeView created by designer with empty constructor, NodeStore will be always null and NodeView is unusable.
Comment 1 wdehoog 2017-07-04 13:07:15 UTC
Same problem for me. My code uses lv.NodeStore.GetNode and it worked but now that always crashes. Have to derive NodeView and keep a reference to the store to be able to use it.
Comment 2 David Lechner 2017-11-19 02:52:05 UTC
Confirmed. This was broken by https://github.com/mono/gtk-sharp/commit/923585a4b17642f27acadfa55f71531293387246
Comment 3 David Lechner 2017-11-19 02:54:35 UTC
Patch: https://github.com/mono/gtk-sharp/pull/214
Comment 4 David Lechner 2017-11-19 02:57:45 UTC
Workaround: use reflection to set private store field after setting property

var nodeView = new NodeView ();
var nodeStore = new NodeStore (typeof (MyNode));
nodeview.NodeStore = nodeStore;
typeof (NodeView).GetField ("store", BindingFlags.Instance | BindingFlags.NonPublic).SetValue (nodeview, nodeStore);
Comment 5 master-chi 2018-02-28 19:46:27 UTC
Fix is merged long ago so closing.