Bug 51679 - Previewer doesn't show selected state for Device or Platform after experiencing an error
Summary: Previewer doesn't show selected state for Device or Platform after experienci...
Status: RESOLVED ANSWERED
Alias: None
Product: Visual Studio Extensions
Classification: Xamarin
Component: Xamarin.Forms Previewer ()
Version: 4.3.0 (C9)
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2017-01-20 23:50 UTC by David Ortinau [MSFT]
Modified: 2017-04-18 13:44 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
environment notes (2.57 KB, text/plain)
2017-01-20 23:50 UTC, David Ortinau [MSFT]
Details
project (6.51 MB, application/x-zip-compressed)
2017-01-21 00:26 UTC, David Ortinau [MSFT]
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED ANSWERED

Description David Ortinau [MSFT] 2017-01-20 23:50:40 UTC
Created attachment 19423 [details]
environment notes

I hit an error the first time I loaded the previewer and noticed the Device and Platform buttons were all grey (disabled looking).

I corrected the error and the preview rendered the view, however the Device and Platform buttons all remained deselected. I know I want Android and my Mac agent is not connected, but visually this is not indicated.

I can select the options and the selected state does persist.
Comment 1 David Ortinau [MSFT] 2017-01-21 00:26:09 UTC
Created attachment 19431 [details]
project

It might be worth noting my selected startup Forms target project is UWP and neither iOS or Android.
Comment 2 Alan McGovern 2017-02-01 15:40:37 UTC
Can you screencast the problem? It seems to work fine for me for both kinds of error:

https://screencast.com/t/usRbfEEz0n
Comment 3 David Ortinau [MSFT] 2017-02-24 17:01:57 UTC
https://www.screencast.com/t/GmlC6wHjKB

Here's my screencast. The tabs never indicate what I'm looking at, phone + android.
Comment 4 Alan McGovern 2017-04-18 13:34:53 UTC
If this is still reproducible with 15.2 or master builds then let me know. I still can't reproduce the issue and cannot find any code that would cause the buttons to look like they are in the disabled state.

At the moment I am unable to test the project you provided as neither the iOS or Android project can be compiled when working with a locally built version of XVS.
Comment 5 Alan McGovern 2017-04-18 13:40:44 UTC
Actually i think i can just close this. There is a commit from November 16th which removed the code to enable/disable the buttons. I'll assume this patch was *not* in the build you were testing with, but it should already be in stable. 

 https://github.com/xamarin/md-addins/commit/7eeff855b8f52db7991d82cf06bbf8a158ade7c7
Comment 6 Alan McGovern 2017-04-18 13:44:16 UTC
For reference, this patch should have been in every release since C9 went to stable.