Bug 5099 - Variable inside loop inside iteration method not properly closed over
Summary: Variable inside loop inside iteration method not properly closed over
Status: RESOLVED FIXED
Alias: None
Product: Compilers
Classification: Mono
Component: C# ()
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2012-05-15 16:03 UTC by Brett Ernst
Modified: 2012-05-16 14:41 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Small repro (639 bytes, text/plain)
2012-05-15 16:03 UTC, Brett Ernst
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Brett Ernst 2012-05-15 16:03:25 UTC
Created attachment 1894 [details]
Small repro

It appears that when you close over a variable inside a loop that is, in turn, inside an iterator method, the variable is not properly scoped and may end up with the wrong value when the delegate is called. This is a bit convoluted, but see the attached repro.

Compiled in .NET 3.5/4.0/4.5, the output is "foo", but in Mono 2.10.x, the output is "bar".

Apologies if this was fixed already in 2.11; I don't have access to that version at the moment. I know the foreach closure behavior has changed, but I'm not sure if this is related to its use inside an iterator method.
Comment 1 Marek Safar 2012-05-16 14:41:41 UTC
Already fixed in master (most likely 2.11 too but didn't test it)