Bug 50454 - device-specific build directories not cleaned with xbuild /t:Clean
Summary: device-specific build directories not cleaned with xbuild /t:Clean
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: MSBuild ()
Version: master
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-12-20 16:02 UTC by Jeffrey Stedfast
Modified: 2016-12-20 16:37 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Jeffrey Stedfast 2016-12-20 16:02:12 UTC
Up until yesterday, the MSBuild targets had the following logic:

<Target Name="_CleanDeviceSpecificOutput" Condition="'$(_CanOutputAppBundle)' == 'true'">
    <RemoveDir SessionId="$(BuildSessionId)" Condition="'$(IsMacEnabled)' == 'true'" Directories="$(IntermediateOutputPath)build-*;$(OutputPath)build-*" />
</Target>

The problem with this logic is that RemoveDir does not interpret wildcards.

You might think that the solution would be to do:

<ItemGroup>
    <_DeviceSpecificBuildDirs Include="$(IntermediateOutputPath)build-*" />
    <_DeviceSpecificBuildDirs Include="$(OutputPath)build-*" />
</ItemGroup>

buuuuuut, you'd be wrong because while the Include parameter above normally expands, it only matches *files* and not directories. Since those wildcards do not match any files, they evaluate to nothingness.

Sebastien suggested the idea that perhaps what should be done is that these build-* directories should be:

$(IntermediateOutputPath)device-builds\build-*
$(OutputPath)device-builds\build-*

This way, the _CleanDeviceSpecificOutput target could simply RemoveDir $(IntermediateOutputPath)device-builds and $(OutputPath)device-builds