Bug 49790 - [UI review] New session dialog sections unclear
Summary: [UI review] New session dialog sections unclear
Status: VERIFIED FIXED
Alias: None
Product: Profiler
Classification: Xamarin
Component: General ()
Version: 1.0.x
Hardware: PC Mac OS
: Normal normal
Target Milestone: (C9)
Assignee: Jose Medrano
URL:
Depends on:
Blocks:
 
Reported: 2016-12-13 10:53 UTC by Rodrigo Moya
Modified: 2016-12-26 06:27 UTC (History)
9 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Rodrigo Moya 2016-12-13 10:53:01 UTC
Sidebar label names are quite generic and not meaningful. Rename “General” to “Target” and “Advanced” to “Options” could be better.
Comment 1 xamarin-release-manager 2016-12-16 11:10:02 UTC
Fixed in version 1.1.99.128 (master)

Author: Jose?? Medrano
Commit: d2c9e51e96ce54e60d9cd4bef3aed993d0ca75ed (xamarin/profiler)
Comment 2 Saurabh 2016-12-20 07:07:12 UTC
I have checked this Issue with master Xamarin.Profiler 1.1.99.154 and getting new labels 'Target' and 'Options' on New session dialog. This is the screencast for the same: https://www.screencast.com/t/1HWHeP9k0

Xamarin.Profiler
Version: 1.1.99

I have checked the same with latest Cycle8 build (Xamarin.Profiler 1.0.4.14). But I am still getting old labels.

I'll verify the Issue once fixed will be merged into Cycle8 build.
Comment 3 Shruti 2016-12-21 11:30:20 UTC
Any updates to fix this issue in C8SR2 lane?
Comment 4 Shruti 2016-12-21 11:53:05 UTC
(In reply to Shruti from comment #3)
> Any updates to fix this issue in C8SR2 lane?

Corrections.... looking for updates of it's cherry pick.
Comment 5 Rodrigo Moya 2016-12-21 12:31:09 UTC
The patch that fixes this will be included in C8SR2 if and only if we have to do another update, as it missed the deadline (as it was fixed in master while the final-at-that-time C8SR2 builds were being QA'ed).

So, we have it in the list of patches to backport to C8 branch if we ever need to do a C8SR3 (or SR2 update), but since it's not a blocker nor an important fix, I don't think we should do another build to QA at this time for C8SR2.

From the profiler point of view, we just need to cherry-pick a commit, so not a big deal, so Luis/Oleg, should we just move this to C9?
Comment 6 Luis Aguilera 2016-12-21 12:55:11 UTC
Moving to c9
Comment 7 Akhilesh kumar 2016-12-26 06:27:32 UTC
I have checked this issue with latest c9 build and now we getting new labels 'Target' and 'Options' on New session dialog.

Screencast: https://www.screencast.com/t/PEnE9ngrFA

So I am closing this issue.

C9 Profiler build info: profiler-mac-1.1.3-52_bdcbdffa84323e09b90a71a2d44b755737a7c604

Environment info: https://gist.github.com/AkhileshKumar01/4236bfea2473ee54ed6cf1ddfffd578b