Bug 4913 - Commit/Review Changes is confusing
Summary: Commit/Review Changes is confusing
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Version Control ()
Version: Trunk
Hardware: PC Mac OS
: --- enhancement
Target Milestone: ---
Assignee: Alan McGovern
URL:
Depends on:
Blocks:
 
Reported: 2012-05-07 00:11 UTC by Mikayla Hutchinson [MSFT]
Modified: 2013-07-30 07:07 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mikayla Hutchinson [MSFT] 2012-05-07 00:11:57 UTC
It's confusing that the Commit command is only shown for folders, not for files. We should also remove the commit command, since Review Changes is better, and there's no good reason to support both.
Comment 1 Marius Ungureanu 2013-07-16 11:47:56 UTC
Commit is now also available for files. Don't know if this report is still valid.
Comment 2 Mikayla Hutchinson [MSFT] 2013-07-16 12:25:54 UTC
Good question. Personally I think that committing without review is dangerous, so I would remove Commit, and rename Review Changes to Commit to make it more discoverable... but we need more than just my opinion on this.

Lluis?
Comment 3 Marius Ungureanu 2013-07-23 12:38:50 UTC
We should add a button that would open review changes and close the commit window, no? :D
Comment 4 Lluis Sanchez 2013-07-29 06:38:39 UTC
Hard to tell what's better. I like the idea of having a single window for review and commit, since it provides a better workflow and user experience. However, some users may like the simple interface of the commit window for quick commits.

Let's try hiding the commit command and rename "Review Changes" to "Review and Commit". If we have valid user objections, we can easily rollback.
Comment 5 Marius Ungureanu 2013-07-30 07:07:17 UTC
PR #357 should take care of this. Will mark as fixed.