Bug 48734 - System.IO.Compression.ZipArchive.CreateEntry completely discards CompressionLevel argument
Summary: System.IO.Compression.ZipArchive.CreateEntry completely discards CompressionL...
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: General ()
Version: 4.6.0 (C8)
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2016-12-02 17:19 UTC by Aaron Bockover [MSFT]
Modified: 2017-01-04 22:38 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Aaron Bockover [MSFT] 2016-12-02 17:19:19 UTC
Because System.IO.Compression.ZipArchive.CreateEntry completely discards the CompressionLevel argument, one cannot properly add zero-byte archive entries.

CompressionLevel.NoCompression should be translated to SharpZipLib's CompressionMethod.Stored to ensure the entry is stored but not compressed.

Without translating NoCompression to Stored, invalid archives are created:

$ unzip foo.zip
  inflating: subdir/untracked-single-byte-dependency
  inflating: subdir/untracked-zero-byte-dependency
  error:  invalid compressed data to inflate
  inflating: subdir/another/banana.jpg

The corefx System.IO.Compression (NuGet) correctly handles CompressionLevel.NoCompression:

$ unzip foo.zip
  inflating: subdir/untracked-single-byte-dependency
 extracting: subdir/untracked-zero-byte-dependency
  inflating: subdir/another/banana.jpg

It further does the right thing when the argument is omitted (defaulting to CompressionLevel.Optimal) by presumably setting the entry to stored instead of compressed if _no data was written to the archive stream_.

We will be using the NuGet from corefx from now on, since it also eliminates the SharpZipLib dependency, but I wanted to file this regardless.
Comment 1 Marek Safar 2017-01-04 22:38:56 UTC
mono master now uses CoreFX implementation which should resolved this issue as well.