Bug 48703 - Typo in public property name UseSafairReaderMode in Plugin.Share
Summary: Typo in public property name UseSafairReaderMode in Plugin.Share
Status: RESOLVED FIXED
Alias: None
Product: Components
Classification: Xamarin
Component: Xamarin Components ()
Version: N/A
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bill Holmes
URL:
Depends on:
Blocks:
 
Reported: 2016-12-02 12:29 UTC by John Hardman
Modified: 2016-12-15 15:35 UTC (History)
3 users (show)

Tags: Share.Plugin UseSafairReaderMode UseSafariReaderMode BrowserOptions
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description John Hardman 2016-12-02 12:29:53 UTC
In James Montemagno's Share plugin, the public property name "BrowserOptions.UseSafairReaderMode" is spelled incorrectly. It should be "BrowserOptions.UseSafariReaderMode"

Could this be fixed, either as a breaking change, or by adding a new property and marking the old one Obsolete.
Comment 1 Pierce Boggan [MSFT] 2016-12-15 15:35:39 UTC
Thanks for the report, John!

The Share Plugin is an open-source community project that isn't maintained by Xamarin. It's probably best to file issues related to Plugins for Xamarin on the individual plugin repo on GitHub (master list [1]) so the individual community author (in this case Jacob and James) can be notified. :)

As an FYI, this seems to be fixed in the latest `master` branch for the Share Plugin:
https://github.com/jguertl/SharePlugin/blob/master/Share/Share.Plugin.Abstractions/BrowserOptions.cs#L23

[1] https://github.com/xamarin/XamarinComponents#community-provided-open-source-plugins