Bug 4836 - On the fly formatting should be an atomic undo
Summary: On the fly formatting should be an atomic undo
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: Trunk
Hardware: PC Mac OS
: Normal normal
Target Milestone: 3.0
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2012-05-02 17:53 UTC by Mikayla Hutchinson [MSFT]
Modified: 2012-05-09 05:04 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mikayla Hutchinson [MSFT] 2012-05-02 17:53:45 UTC
Bug 3000 seems to have regressed.

When the on the fly formatter is triggered by a semicolon, undoing it removes the semicolon.
Comment 1 Mike Krüger 2012-05-03 03:14:42 UTC
it removes the semicolon + formatting changes.

Since it's one operation this is correct. The issue is that a undo there that don't remove the semicolon doesn't make sense.
Comment 2 Mikayla Hutchinson [MSFT] 2012-05-03 12:45:24 UTC
The problem is, if the formatter makes unwanted changes, it's impossible to revert them. The formatting *is* a separate operation, just one that happens to be triggered by the semicolon. Visual Studio does it like I suggested, probably for this reason.
Comment 3 Mike Krüger 2012-05-09 05:04:02 UTC
should work now.