Bug 47288 - Excessive build times due to GetAdditionalResourcesFromAssemblies
Summary: Excessive build times due to GetAdditionalResourcesFromAssemblies
Status: RESOLVED FIXED
Alias: None
Product: Android
Classification: Xamarin
Component: MSBuild ()
Version: 7.0 (C8)
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: dean.ellis
URL:
: 52160 ()
Depends on:
Blocks:
 
Reported: 2016-11-17 22:27 UTC by Jeremy Kolb
Modified: 2017-03-23 20:54 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Jeremy Kolb 2016-11-17 22:27:53 UTC
See https://forums.xamarin.com/discussion/comment/234337 for the details.
Comment 1 Patryk 2016-11-18 08:43:42 UTC
Same thing described here:
https://forums.xamarin.com/discussion/82341/build-time-is-too-long

before fix - current Xamarin version:
(...)
7881 ms Aapt 14 calls
8887 ms CompileToDalvik 1 calls
52924 ms GetAdditionalResourcesFromAssemblies 1 calls
Build succeeded.
*Time Elapsed 00:01:25.23*

after disabling GetAdditionalResourcesFromAssemblies:
(...)
699 ms ConvertResourcesCases 3 calls
712 ms Copy 9 calls
770 ms RemoveDirFixed 9 calls
1161 ms CreateAdditionalLibraryResourceCache 1 calls
1842 ms GenerateJavaStubs 1 calls
3671 ms Javac 1 calls
6736 ms CompileToDalvik 1 calls
9281 ms Aapt 14 calls
Build succeeded.
*Time Elapsed 00:00:27.55*
Comment 2 Patryk 2016-11-18 08:47:47 UTC
Probably duplicate:
https://bugzilla.xamarin.com/show_bug.cgi?id=47288
Comment 3 Jeremy Kolb 2016-11-18 15:23:14 UTC
@Patryk that looks like the same bug.
Comment 4 dean.ellis 2016-11-23 10:52:42 UTC
Fixed in xamarin-android/master/2f690ca7

This has also been cherry-picked to the cycle9 branch. 

xamarin-android/cycle9/104faeaa
Comment 5 dean.ellis 2017-02-07 10:23:16 UTC
*** Bug 52160 has been marked as a duplicate of this bug. ***
Comment 6 Joey Z 2017-02-09 00:30:48 UTC
How do I tell which build has this bug fix in it?  I looked at the release notes for the current beta and alpha but did not see 47288 anywhere.  I'm assuming that this bug number corresponds to the release notes that say something like:

Fixed: 45134 - "Go to folder" shortcut in file dialogs doesn't accept Cmd+v.

I looked for "Fixed: 47288" but could not find it in beta or alpha.
Comment 7 Joey Z 2017-02-09 01:14:57 UTC
I found it in beta channel by manually testing.  My build times have shrunk by about 4 minutes.  Thanks for fixing this bug!
Comment 8 Brendan Zagaeski (Xamarin Team, assistant) 2017-03-23 20:54:58 UTC
(This comment is partly just for my own future reference.)


## Bookkeeping note on the location of the change mentioned in Comment 4

> INCLUDED     in Xamarin.Android 7.2.0.2  "15.1 Beta Preview 1"       (which uses https://github.com/xamarin/xamarin-android/tree/1a2330336b9c0499efee5c85566a0e99bc437b96)
> INCLUDED     in Xamarin.Android 7.1.0.43 "Cycle 9 Service Release 0" (which uses https://github.com/xamarin/xamarin-android/tree/cc7bde0678a031a0afd383a4e14521070920d9f3)
> INCLUDED     in Xamarin.Android 7.1.0.41 "Cycle 9"                   (which uses https://github.com/xamarin/xamarin-android/tree/cc7bde0678a031a0afd383a4e14521070920d9f3)
> NOT included in Xamarin.Android 7.0.2.42 "Cycle 8 Service Release 2" (which uses https://github.com/xamarin/xamarin-android/tree/124e901b81999911c550ea0a207b1180fc4531c8)