Bug 4699 - Git Dialog Box, tends to error out with ugly exceptions
Summary: Git Dialog Box, tends to error out with ugly exceptions
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Version Control ()
Version: 2.9.x
Hardware: PC Mac OS
: Normal normal
Target Milestone: ---
Assignee: Alan McGovern
URL:
Depends on:
Blocks:
 
Reported: 2012-04-27 15:10 UTC by Miguel de Icaza [MSFT]
Modified: 2014-12-13 22:30 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Miguel de Icaza [MSFT] 2012-04-27 15:10:23 UTC
It is relatively easy to enter incorrect data on the Version Control/Checkout dialog box, and when an error happens, instead of going back tot he dialog box, we produce a dialog box with an exception and we have to re-enter all the data.

1. When we select a directory that is not empty:

http://screencast.com/t/aCSu61NoAZDY

2. When we provide invalid data:

http://screencast.com/t/aCSu61NoAZDY

----

We should do two things: (a) some basic validation while entering the form, which currently is missing at least the empty directory check.

(b) Keep the dialog box with the Checkout around, and if there is an error, go back to it to keep its values preserved.

(c) Catch these exceptions and provide a better error message for some of these conditions than a stacktraces:

 NGit.Errors.NotSupportedException

This is a list of all the exceptions that we could use to print a better message:


AmbiguousObjectException
CheckoutConflictException
CompoundException
ConfigInvalidException
CorruptObjectException
EntryExistsException
GitlinksNotSupportedException
IncorrectObjectTypeException
IndexWriteException
InvalidObjectIdException
InvalidPatternException
LargeObjectException
LockFailedException
MissingBundlePrerequisiteException
MissingObjectException
NoClosingBracketException
NoRemoteRepositoryException
NoWorkTreeException
NotSupportedException
ObjectWritingException
PackInvalidException
PackMismatchException
PackProtocolException
RemoteRepositoryException
RepositoryNotFoundException
RevWalkException
RevisionSyntaxException
StopWalkException
StoredObjectRepresentationNotAvailableException
SymlinksNotSupportedException
TooLargeObjectInPackException
TranslationBundleException
TranslationBundleLoadingException
TranslationStringMissingException
TransportException
UnmergedPathException
UnpackException
UnsupportedCredentialItem
Comment 1 Lluis Sanchez 2013-07-03 04:55:27 UTC
We have to consider how to handle errors in the new design of the version control UX
Comment 2 Marius Ungureanu 2014-12-13 22:30:39 UTC
The Exception dialog is no more. I added a VersionControlException (some time ago) that is to be used when having to show something to the user or just that it's expected to be thrown.