Bug 46631 - TabbedPage BarBackgroundColor & BarTextColor never changed after initialization
Summary: TabbedPage BarBackgroundColor & BarTextColor never changed after initialization
Status: RESOLVED ANSWERED
Alias: None
Product: Forms
Classification: Xamarin
Component: Android ()
Version: 2.3.3
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-11-09 11:54 UTC by Serge
Modified: 2016-11-14 09:02 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED ANSWERED

Description Serge 2016-11-09 11:54:15 UTC
OnElementPropertyChanged in TabbedPageRenderer is broken.

Due to the lack of brackets in OnElementPropertyChanged method, UpdateBarBackgroundColor and UpdateBarTextColor are never called.

To fix it, simply change 

if (e.PropertyName == nameof(TabbedPage.CurrentPage))
				if(Element.CurrentPage != null)
					ScrollToCurrentPage();

to 

if (e.PropertyName == nameof(TabbedPage.CurrentPage))
{
				if(Element.CurrentPage != null)
					ScrollToCurrentPage();
}
Comment 1 adrianknight89 2016-11-10 18:53:42 UTC
Which file are you talking about? Is it AppCompat\TabbedPageRenderer.cs? I already see curly braces.
Comment 2 Serge 2016-11-11 08:42:42 UTC
Oh, sorry.

Now I see it's fixed is master branch, but issue is in 2.3.3-pre4.

https://github.com/xamarin/Xamarin.Forms/blob/2.3.3/Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs

I think you can close this bug.
Comment 3 adrianknight89 2016-11-13 02:30:42 UTC
I don't have the permissions to close it. Can you do it yourself? There should be an "Edit" button next to "Status: NEW". Set it to resolved answered.