Created attachment 18294 [details]
Diagnostic build output for both BAD and GOOD versions

[XVS 4.2.0.719] "C:\Program Files (x86)\MSBuild\Xamarin\Android\mono-symbolicate ... Assertion at ..\mono\metadata\class.c:5078, condition `class' not met" when attempting to create Android packages in the Release configuration


As mentioned in duplicate Bug 46164, Comment 13, this issue appears to be caused by a "bad" copy of `mono-symbolicate.exe` that was somehow packaged into this _specific_ Xamarin.VisualStudio installer.

Could this have been caused by a build environment issue on the particular build bot that created this particular installer package?  That could potentially explain why the issue has somewhat "mysteriously" appeared and disappeared in other earlier reports of the problem:

- Bug 43833
- Bug 44105




## Partial workaround

Open the Android app project .csproj file in a text editor and change the following line anywhere that it appears to say "false" instead of "true":

<AndroidManagedSymbols>true</AndroidManagedSymbols>

(Note that this will _disable_ the mono-symbolicate step entirely, so you might prefer to upgrade to the current Beta version (from 2016-11-01) or downgrade to the previous Stable version (from 2016-10-04) instead to be able to continue to take advantage of the mono-symbolicate feature.)




## Regression status: Regression in XamarinVS 4.2.0.719 compared to 4.2.0.703

> BAD:  XamarinVS 4.2.0.719 (15694b9) (with Xamarin.Android 7.0.1.6  (5a02b03)) "Xcode 8.1 compatibility update"      (2016-10-27)
> GOOD: XamarinVS 4.2.0.703 (3b7df6f) (with Xamarin.Android 7.0.1.3  (96c7ba6)) "Cycle 8 – Service Release 0"         (2016-10-04)
> GOOD: XamarinVS 4.2.0.680 (c4382f5) (with Xamarin.Android 7.0.0.18 (0e59c36)) "Cycle 8"                             (2016-09-13)



## Verification status: verified not replicable in the current 2016-11-01 Beta builds of "Cycle 8 – Service Release 1"

> GOOD: XamarinVS 4.2.1.52  (76d5fac) (with Xamarin.Android 7.0.2.37 (ce955cc)) "Cycle 8 – Service Release 1, Beta 2" (2016-11-01)
> BAD:  XamarinVS 4.2.0.719 (15694b9) (with Xamarin.Android 7.0.1.6  (5a02b03)) "Xcode 8.1 compatibility update"      (2016-10-27)



## mono-symbolicate.exe file version info

> GOOD 4.2.1.52  (76d5fac): 11/01/2016  11:07 AM  6,600,704  mono-symbolicate.exe  (MD5: 1cd12d6b3720b9d3bbde5993cfa6b62b)
> BAD  4.2.0.719 (15694b9): 10/27/2016  01:06 PM  6,508,544  mono-symbolicate.exe  (MD5: 28504c4d448ed5971759d46d9e454739)
> GOOD 4.2.0.703 (3b7df6f): 10/04/2016  07:09 AM  6,600,704  mono-symbolicate.exe  (MD5: c5dea2411ae56305b962105b596db9c4)
> GOOD 4.2.0.680 (c4382f5): 09/12/2016  07:46 PM  6,600,704  mono-symbolicate.exe  (MD5: d74e5126deb5a1d0a12ff247056bb1fc)



## Steps to replicate


1. Create a new "Visual C# > Android > Blank App (Android)" project.

Side note: In all of the versions that I tested for verification and regression (as recorded above), this template app sets the `<AndroidManagedSymbols>true</AndroidManagedSymbols>` property as part of the "Release|AnyCPU" configuration, so the build process _does_ try to run the mono-symbolicate program in every case.


2. Run the "PackageForAndroid" target on the project in the "Release" configuration.  For example, run the following msbuild command (example for MSBuild Tools 2015):

"C:\Program Files (x86)\MSBuild\14.0\Bin\MSBuild.exe" /p:Configuration="Release" /t:PackageForAndroid AndroidApp1\AndroidApp1.csproj




## BAD Results

The build fails due to an error when running `mono-symbolicate.exe`.

### Excerpt from the BAD diagnostic MSBuild output for the _CopyPackage target with XamarinVS 4.2.0.719 (15694b9)

> Task "Exec" (TaskId:200)
>   Task Parameter:Command="C:\Program Files (x86)\MSBuild\Xamarin\Android\mono-symbolicate" store-symbols "bin\Release\AndroidApp1.AndroidApp1.apk.mSYM" "obj\Release\android/assets" (TaskId:200)
>   "C:\Program Files (x86)\MSBuild\Xamarin\Android\mono-symbolicate" store-symbols "bin\Release\AndroidApp1.AndroidApp1.apk.mSYM" "obj\Release\android/assets" (TaskId:200)
>   * Assertion at ..\mono\metadata\class.c:5078, condition `class' not met (TaskId:200)
>    (TaskId:200)
> C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(2289,3): error MSB3073: The command ""C:\Program Files (x86)\MSBuild\Xamarin\Android\mono-symbolicate" store-symbols "bin\Release\AndroidApp1.AndroidApp1.apk.mSYM" "obj\Release\android/assets"" exited with code -1073740791. [C:\source\AndroidApp1\AndroidApp1\AndroidApp1.csproj]
> Done executing task "Exec" -- FAILED. (TaskId:200)



## GOOD Results

The `mono-symbolicate` Exec task runs and does not cause the build to abort.



### Excerpt from the GOOD diagnostic MSBuild output for the _CopyPackage target with XamarinVS 4.2.1.52 (76d5fac) or 4.2.0.703 (3b7df6f)

> Task "Exec" (TaskId:200)
> Task Parameter:Command="C:\Program Files (x86)\MSBuild\Xamarin\Android\mono-symbolicate" store-symbols "bin\Release\AndroidApp1.AndroidApp1.apk.mSYM" "obj\Release\android/assets" (TaskId:200)
> "C:\Program Files (x86)\MSBuild\Xamarin\Android\mono-symbolicate" store-symbols "bin\Release\AndroidApp1.AndroidApp1.apk.mSYM" "obj\Release\android/assets" (TaskId:200)
> Done executing task "Exec". (TaskId:200)



## Additional testing environment info (brief)

Microsoft Visual Studio Enterprise 2015
Version 14.0.25425.01 Update 3
Microsoft .NET Framework
Version 4.6.01055

Windows 8.1 Version 6.3 (Build 9600)