Bug 45851 - Markdown-style links that are interpreted as "Dos Path" links cause fatal crash.
Summary: Markdown-style links that are interpreted as "Dos Path" links cause fatal crash.
Status: VERIFIED FIXED
Alias: None
Product: Workbooks & Inspector
Classification: Xamarin
Component: Client: Mac ()
Version: master
Hardware: PC Mac OS
: --- normal
Target Milestone: 1.1
Assignee: xamarininteractive
URL:
Depends on:
Blocks:
 
Reported: 2016-10-24 19:18 UTC by Larry O'Brien
Modified: 2017-02-23 16:15 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Workbook with crash-causing link. (95 bytes, text/plain)
2016-10-24 19:18 UTC, Larry O'Brien
Details
screencast demonstrating behavior (4.17 MB, video/mp4)
2016-11-21 18:46 UTC, Larry O'Brien
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Larry O'Brien 2016-10-24 19:18:26 UTC
Created attachment 18204 [details]
Workbook with crash-causing link.

If a workbook contains a markdown-style link that ends up being interpreted as a "Dos path", the Xamarin Workbooks app crashes (not just the workbook). 

Example: This will go [boom](T:Boom). 



I _would_ say this was minor, since the odds are 99% that it's an ill-formed URL in the first place (I accidentally inserted such links programmatically). _But_ the crash is fatal, so... 

Logs say: 

[Critical][1.02:59:28.9686310] AppDomain (ConfigureLogging): exception: System.UriFormatException: Invalid URI: A Dos path must be rooted, for example, 'c:\'.
  at System.Uri.CreateThis (System.String uri, System.Boolean dontEscape, System.UriKind uriKind) [0x00090] in <d41cde7243c545cbb22c23ad14c961b6>:0 
  at System.Uri..ctor (System.String uriString, System.UriKind uriKind) [0x00017] in <d41cde7243c545cbb22c23ad14c961b6>:0 
  at Foundation.NSUrl.op_Implicit (Foundation.NSUrl url) [0x0001d] in <9785f0bb44024a89b9070044eadfc6a1>:0 
  at Xamarin.Interactive.Client.Mac.ReplWebView+XIWebPolicyDelegate.DecidePolicyForNavigation (WebKit.WebView webView, Foundation.NSDictionary actionInformation, Foundation.NSUrlRequest request, WebKit.WebFrame frame, Foundation.NSObject decisionToken) [0x00045] in <b3ffd1bb9b434847af5ba097b6650d55>:0 
  at (wrapper managed-to-native) AppKit.NSApplication:NSApplicationMain (int,string[])
  at AppKit.NSApplication.Main (System.String[] args) [0x0003d] in <9785f0bb44024a89b9070044eadfc6a1>:0 
  at Xamarin.Interactive.Client.Mac.Entry.Main (System.String[] args) [0x00005] in <b3ffd1bb9b434847af5ba097b6650d55>:0  </Users/builder/data/lanes/904/3a37c49d/source/inspector/Clients/Xamarin.Interactive.Client/AppSession.cs:86>