Bug 45168 - XmlDsigExcC14NTransform adds redundant namespace attribute
Summary: XmlDsigExcC14NTransform adds redundant namespace attribute
Status: NEW
Alias: None
Product: Class Libraries
Classification: Mono
Component: System.Security ()
Version: 4.2.3 (C6SR3)
Hardware: PC Linux
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-10-07 12:51 UTC by ivan12
Modified: 2016-10-07 12:51 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 45168 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description ivan12 2016-10-07 12:51:38 UTC
XmlDsigExcC14NTransform can add redundant namespace attribute, so the resulting XML is not correctly canonicalized.
Sample code to reproduce this issue:

using System;
using System.IO;
using System.Security.Cryptography.Xml;
using System.Text;
using System.Xml;

public class Program
{
    public static void Main(string[] args)
    {
        var doc = new XmlDocument();
        doc.LoadXml(
        @"<ns1:A xmlns:ns1=""ns1""><B><ns1:C/></B></ns1:A>");
        
        var t = new XmlDsigExcC14NTransform();
        t.LoadInput(doc);
        var ms = (MemoryStream)t.GetOutput();
        
        Console.WriteLine(Encoding.UTF8.GetString(ms.ToArray()));
    }
}


When you run this code using Mono:

    mcs ./Program.cs -r:System.Security && mono ./Program.exe

the result is:

    <ns:A xmlns:ns="ns"><B><ns:C xmlns:ns="ns"></ns:C></B></ns:A>

When you run the same program using .NET Framework, you'll get the expected output (without namespace attribute in the C element):

   <ns:A xmlns:ns="ns"><B><ns:C></ns:C></B></ns:A>


This behaviour is caused by method XmlCanonicalizer.WriteNamespacesAxis, which incorrectly determines that namespace from A element is not visible and writes the same namespace attribute again in element C.