Bug 43022 - ZipArchive.Entries is not updated when ZipArchiveEntry is deleted
Summary: ZipArchive.Entries is not updated when ZipArchiveEntry is deleted
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: SharpZipLib ()
Version: 4.7.X
Hardware: Other Other
: --- normal
Target Milestone: Untriaged
Assignee: João Matos
URL:
Depends on:
Blocks:
 
Reported: 2016-08-03 07:09 UTC by Tim Jones
Modified: 2016-08-04 17:36 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Tim Jones 2016-08-03 07:09:44 UTC
Steps to repro:

1. Open a ZipArchive, which contains an existing file - for example, test.txt.
2. Get the ZipArchiveEntry for this file - i.e. zipArchive.GetEntry("test.txt").
3. Delete the ZipArchiveEntry - zipArchiveEntry.Delete().

Expected outcome:
zipArchive.Entries should no longer contain the deleted ZipArchiveEntry. This is what happens in the .NET Framework implementation.

Actual outcome:
zipArchive.Entries does contain the deleted ZipArchiveEntry.

From reading the source code, it looks like ZipArchiveEntry.Delete() calls Archive.zipFile.RemoveEntry(entry) - which removes the entry from SharpCompress.Archive.Zip.ZipArchive's Entries collection, but not System.IO.Compression.ZipArchive.Entries.
Comment 1 João Matos 2016-08-04 12:32:08 UTC
Pushed PR: https://github.com/mono/mono/pull/3357