Bug 42951 - Typo in constant name "CAKeyFrameAnimation.AnimationDescrete"
Summary: Typo in constant name "CAKeyFrameAnimation.AnimationDescrete"
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: General ()
Version: XI 9.8 (tvOS / C7)
Hardware: PC Windows
: Low minor
Target Milestone: Future Cycle (TBD)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-08-01 12:09 UTC by softlion
Modified: 2016-08-02 18:56 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description softlion 2016-08-01 12:09:48 UTC
should be CAKeyFrameAnimation.AnimationDiscrete, not AnimationDescrete
Comment 1 softlion 2016-08-01 12:10:32 UTC
it's on CAAnimation, not CAKeyFrameAnimation
Comment 2 Rodrigo Kumpera 2016-08-01 16:12:45 UTC
Reassigning it to the right team.
Comment 3 Vincent Dondain [MSFT] 2016-08-02 12:56:31 UTC
Nice catch!
Sadly changing that would be a breaking change, we could only XAMCORE_4_0-ify it and we don't know when we'll be able to break our APIs again, might never happen.
Comment 4 softlion 2016-08-02 14:54:57 UTC
You already break it at each new iOS release (at least Apple does it for you).
 Won't be a bad breaking change.
I won't blame you.
With the current name, it is hard to find.
And I suppose we are not much people using this constant.
Comment 5 Sebastien Pouliot 2016-08-02 15:31:37 UTC
No, we're _not_ breaking our binary compatibility with every release (of XI or iOS). That would be breaking all existing components from our store if we did so. Our goal is to ensure a new version of XI can be used with binaries produced with older version. Real breaking changes are very uncommon.

In most cases* we can find a way to "fix" Apple breakage (or our own mistakes*) without breaking our binary compatibility - and whenever it's possible we do so. 

* including this one

In this specific case we can add a, correctly named, `AnimationDiscrete` field. What we can't do is remove the one with a typo: `AnimationDescrete`. OTOH we can annotate it with an [Obsolete] attribute that point people to the right name. That solve the issue (easier to find) and maintains compatibility for any existing binary that refers to the typo'ed symbol.
Comment 6 softlion 2016-08-02 16:24:46 UTC
ok perfect !