Bug 42700 - Follow-up to Bug 42387: Setting the `IpaPackageDir` property to a custom value breaks the logic for the "Show IPA File on Build Server" button
Summary: Follow-up to Bug 42387: Setting the `IpaPackageDir` property to a custom valu...
Status: VERIFIED FIXED
Alias: None
Product: Visual Studio Extensions
Classification: Xamarin
Component: iOS ()
Version: 4.1.0 (C7)
Hardware: PC Windows
: Normal normal
Target Milestone: 4.1.2 (C7SR1)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-07-20 22:06 UTC by Brendan Zagaeski (Xamarin Team, assistant)
Modified: 2016-07-25 09:15 UTC (History)
5 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Test case (14.24 KB, application/zip)
2016-07-20 22:06 UTC, Brendan Zagaeski (Xamarin Team, assistant)
Details
Screenshot of "Show IPA File on Build Server" button (4.70 KB, image/png)
2016-07-20 22:06 UTC, Brendan Zagaeski (Xamarin Team, assistant)
Details
IDE log files and detailed version info (9.35 KB, application/zip)
2016-07-20 22:08 UTC, Brendan Zagaeski (Xamarin Team, assistant)
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Brendan Zagaeski (Xamarin Team, assistant) 2016-07-20 22:06:04 UTC
Created attachment 16734 [details]
Test case

Follow-up to Bug 42387: Setting the `IpaPackageDir` property to a custom value breaks the logic for the "Show IPA File on Build Server" button




## Regression status: new edge case introduced by the new `IpaPackageDir` feature (in "Cycle 7 – Service Release 1")




## Steps to replicate


1. Ensure Visual Studio is connected to a Mac build host.


2. Build the attached test case in the "Ad-Hoc|iPhone" configuration.

The test case is a new template Single View app where the following extra property has been added to the "Ad-Hoc|iPhone" PropertyGroup in the `.csproj` file:

<IpaPackageDir>$(OutputPath)</IpaPackageDir>


3. After the build completes successfully, click the "Show IPA File on Build Server" button on the VS toolbar (see also the image attached in the next comment).




## BAD Results (with customized `IpaPackageDir`)


- Finder does not open any new windows on the Mac build host.


- An error dialog is displayed:

> Microsoft Visual Studio
> 
> Command did not execute successfully due to an unexpected exception. Please check the output window for additional information.


- There are no additional details in the Output > Xamarin window:

> Attempting to Show file in finder. You will be notified when done


- There are no additional details in the `*.Ide.log` file:

> Xamarin.VisualStudio.IOS.Commands.iOSCommandExtension Information: 0 : [2016-07-20 17:41:59.3162] Attempting to Show file in finder. You will be notified when done.




## GOOD Results (with default `IpaPackageDir`)

- The parent directory of the `.ipa` file opens successfully in Finder on the Mac build host.

- No error dialog is displayed.
Comment 1 Brendan Zagaeski (Xamarin Team, assistant) 2016-07-20 22:06:48 UTC
Created attachment 16735 [details]
Screenshot of "Show IPA File on Build Server" button
Comment 2 Brendan Zagaeski (Xamarin Team, assistant) 2016-07-20 22:08:48 UTC
Created attachment 16736 [details]
IDE log files and detailed version info
Comment 4 xamarin-release-manager 2016-07-21 18:54:13 UTC
Fixed in version 99.0.0.2882 (master)

Author: Jose Gallardo
Commit: 5bf2d7ae24ef56fe011064442429eb4dba7d21b0 (xamarin/XamarinVS)
Comment 5 xamarin-release-manager 2016-07-21 18:54:13 UTC
Fixed in version 4.1.2.7 (cycle7)

Author: Jose Gallardo
Commit: 869fdbfe386148cd6f28fdca43f9f9a27a779f29 (xamarin/XamarinVS)
Comment 6 xamarin-release-manager 2016-07-21 18:57:09 UTC
Fixed in version 4.2.0.18 (cycle8)

Author: Jose Gallardo
Commit: 8c5408321de2ec342353a4285dac96df015536d8 (xamarin/XamarinVS)
Comment 7 Shruti 2016-07-25 09:15:08 UTC
***********************
Reproduce Status:
***********************
I am able to reproduce this issue with XVS 4.1.2.2.. Finder does not open any new windows on the Mac build host and an error dialog is displayed:

> Microsoft Visual Studio
> Command did not execute successfully due to an unexpected exception. Please check 

Screencast: 
http://www.screencast.com/t/PE8IoHgIgNQ

****************************************
Verified Status: C7SR1 RC2 (Working fine)
*****************************************
I have checked this issue with C7SR1 RC2 Xamarin.VisualStudio_4.1.2.14 and observed that now it is working fine. The parent directory of the `.ipa` file opens successfully in Finder on the Mac build host.

Screencast: http://www.screencast.com/t/JppbFP853Axu
http://www.screencast.com/t/RAeOnCsL6Q
Environment Info:
https://gist.github.com/Arpit360/bef2cab08015c69cc8360b76fe31b949

****************************************
Verified Status: Master (Working fine)
*****************************************
Working fine with latest Master XVS 99.0.0.2919.

****************************************
Verified Status: Cycle 8 (XVS build is not available )
*****************************************
I have checked C8 XVS lane, Did not get any file upload to storage. I will check on it once get the build.

As per the milestone C7SR1, this issue is working fine. Hence marking as Verified fixed.