Bug 42682 - [messageui] API review due to enums moving from untyped to nint in iOS 10 beta 1
Summary: [messageui] API review due to enums moving from untyped to nint in iOS 10 beta 1
Status: VERIFIED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 9.99 (iOS 10 previews)
Hardware: PC Mac OS
: Normal normal
Target Milestone: Xcode8 (iOS10)
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2016-07-20 09:32 UTC by Vincent Dondain [MSFT]
Modified: 2016-08-31 19:14 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description Vincent Dondain [MSFT] 2016-07-20 09:32:33 UTC
The enums that changed are: MFMailComposeResult, MFMailComposeErrorCode and MessageComposeResult.

Here's a list of the APIs affected by the change that need review:

- MFMailComposeViewControllerDelegate https://github.com/xamarin/xamarin-macios/blob/master/src/messageui.cs#L56-L60

- MFMessageComposeViewControllerDelegate https://github.com/xamarin/xamarin-macios/blob/master/src/messageui.cs#L139-L144

- MFMessageComposeResultEventArgs https://github.com/xamarin/xamarin-macios/blob/master/src/MessageUI/MessageUI2.cs#L69 & https://github.com/xamarin/xamarin-macios/blob/master/src/MessageUI/MessageUI2.cs#L74

- private Mono_MFMessageComposeViewControllerDelegate https://github.com/xamarin/xamarin-macios/blob/master/src/MessageUI/MessageUI2.cs#L110-L114
Comment 1 Sebastien Pouliot 2016-08-30 17:31:17 UTC
MFMailComposeErrorCode is not used anywhere.

MFMailComposeResult and MessageComposeResult are used (once each) as parameters (and alignment should make this ok) and never inside structs.

All were already [1] fixed for XAMCORE_4_0. 
They will be ignored on xtro too [2]

[1] 8bd6a02399304e97583ef9f2729149faa29fbd9e
[2] https://github.com/xamarin/xamarin-macios/pull/710
Comment 2 Sebastien Pouliot 2016-08-30 18:38:42 UTC
Fixed in xamarin-macios/xcode8 f74a7a79111afc4f39e7806f211adfda291dc1da